From: Richard Knutsson <ricknu-0@student.ltu.se>
To: Sumant Patro <sumantp@lsil.com>
Cc: James.Bottomley@SteelEye.com, akpm@osdl.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
neela.kolli@lsi.com, bo.yang@lsi.com, sumant.patro@lsi.com
Subject: Re: [PATCH 3/6] scsi: megaraid_sas - throttle io if FW is busy
Date: Thu, 15 Feb 2007 09:09:42 +0100 [thread overview]
Message-ID: <45D41546.3070907@student.ltu.se> (raw)
In-Reply-To: <1171486194.4188.21.camel@dumbo>
Sumant Patro wrote:
> Checks added in megasas_queue_command to know if FW is able to process
> commands within the timeout period. If number of retries is 2 or more,
> the driver stops sending cmd to FW. IO is resumed when pending cmd count
> reduces to 16 or 10 seconds has elapsed from the time cmds were last
> sent to FW.
>
> Signed-off-by: Sumant Patro <sumant.patro@lsi.com>
> ---
>
> drivers/scsi/megaraid/megaraid_sas.c | 27 +++++++++++++++++++++++++
> drivers/scsi/megaraid/megaraid_sas.h | 3 ++
> 2 files changed, 30 insertions(+)
>
>
[snip]
> diff -uprN linux-feb13-new-p2/drivers/scsi/megaraid/megaraid_sas.h linux-feb13-new-p3/drivers/scsi/megaraid/megaraid_sas.h
> --- linux-feb13-new-p2/drivers/scsi/megaraid/megaraid_sas.h 2007-02-13 07:22:40.000000000 -0800
> +++ linux-feb13-new-p3/drivers/scsi/megaraid/megaraid_sas.h 2007-02-13 11:37:09.000000000 -0800
> @@ -1102,6 +1102,9 @@ struct megasas_instance {
> atomic_t fw_outstanding;
> u32 hw_crit_error;
>
> + u8 is_busy;
>
Why not "bool is_busy:8;"? It obviously is a boolean. I would also think
false/true would be more descriptive then 0/1.
Richard Knutsson
next prev parent reply other threads:[~2007-02-15 8:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-14 20:49 [PATCH 3/6] scsi: megaraid_sas - throttle io if FW is busy Sumant Patro
2007-02-15 8:09 ` Richard Knutsson [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-02-15 23:44 Patro, Sumant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D41546.3070907@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=bo.yang@lsi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=neela.kolli@lsi.com \
--cc=sumant.patro@lsi.com \
--cc=sumantp@lsil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).