public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Douglas Gilbert <dougg@torque.net>,
	James Bottomley <James.Bottomley@SteelEye.com>,
	Joerg Schilling <Joerg.Schilling@fokus.fraunhofer.de>,
	Jens Axboe <jens.axboe@oracle.com>,
	SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] SG: cap reserved_size values at max_sectors
Date: Tue, 20 Feb 2007 13:43:18 -0600	[thread overview]
Message-ID: <45DB4F56.2070006@cs.wisc.edu> (raw)
In-Reply-To: <45DB4CA7.5090007@cs.wisc.edu>

Mike Christie wrote:
> Yeah you are right getting memory is not a problem I replied about that
> in the other mail. You do not have to use it, but the min of the
> reserved buffer and max_sectors or max_hw_sectors could still be off for
> drivers that do not support clustering or if there is a weird arch
> segment boundary or limit (maybe the arch segment limits and boundary is
> not used much though).
> 
Oh yeah, to handle the clustering I think you could just stick a check
in the sg reserved buffer allocation code to handle that. You could also
stick the max sectors check in there too if you wanted the reserved
buffer to then reflect what was reserved and what a device could handle
at the same time. I am not sure about those other arch segment limits
though. I though I saw something from parsic or something before, but I
am still working on the reserved buffer fixes and just stared digging
into that.

  reply	other threads:[~2007-02-20 19:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-20 16:01 [PATCH] SG: cap reserved_size values at max_sectors Alan Stern
2007-02-20 17:42 ` Mike Christie
2007-02-20 18:03   ` Mike Christie
2007-02-20 18:17   ` Alan Stern
2007-02-20 19:31     ` Mike Christie
2007-02-20 19:43       ` Mike Christie [this message]
2007-02-20 19:44       ` Alan Stern
2007-04-04 18:51 ` Douglas Gilbert
  -- strict thread matches above, loose matches on Subject: below --
2007-03-05 22:22 Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45DB4F56.2070006@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=James.Bottomley@SteelEye.com \
    --cc=Joerg.Schilling@fokus.fraunhofer.de \
    --cc=dougg@torque.net \
    --cc=jens.axboe@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox