From: "Darrick J. Wong" <djwong@us.ibm.com>
To: linux-scsi@vger.kernel.org
Cc: Tejun Heo <htejun@gmail.com>, alexisb@us.ibm.com
Subject: [PATCH 1/2] sas_ata: Rename ata_queued_cmd->lldd_task to driver_data
Date: Thu, 22 Feb 2007 13:39:53 -0800 [thread overview]
Message-ID: <45DE0DA9.7000200@us.ibm.com> (raw)
In-Reply-To: <45C98421.7020907@gmail.com>
Per Tejun's request, rename the lldd_task field and add comments about it.
Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
---
drivers/scsi/libsas/sas_ata.c | 8 ++++----
include/linux/libata.h | 4 +++-
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index 2db2589..c92f4b6 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -122,7 +122,7 @@ static void sas_ata_task_done(struct sas
}
}
- qc->lldd_task = NULL;
+ qc->driver_data = NULL;
if (qc->scsicmd)
ASSIGN_SAS_TASK(qc->scsicmd, NULL);
ata_qc_complete(qc);
@@ -192,7 +192,7 @@ static unsigned int sas_ata_qc_issue(str
task->scatter = qc->__sg;
task->ata_task.retry_count = 1;
task->task_state_flags = SAS_TASK_STATE_PENDING;
- qc->lldd_task = task;
+ qc->driver_data = task;
switch (qc->tf.protocol) {
case ATA_PROT_NCQ:
@@ -276,10 +276,10 @@ static void sas_ata_post_internal(struct
* bother with sas_ata_task_done. But we still
* ought to abort the task.
*/
- struct sas_task *task = qc->lldd_task;
+ struct sas_task *task = qc->driver_data;
unsigned long flags;
- qc->lldd_task = NULL;
+ qc->driver_data = NULL;
if (task) {
/* Should this be a AT(API) device reset? */
spin_lock_irqsave(&task->task_state_lock, flags);
diff --git a/include/linux/libata.h b/include/linux/libata.h
index a20646c..a8eafc7 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -445,7 +445,9 @@ struct ata_queued_cmd {
ata_qc_cb_t complete_fn;
void *private_data;
- void *lldd_task;
+
+ /* This is owned by a low level libata client */
+ void *driver_data;
};
struct ata_port_stats {
next prev parent reply other threads:[~2007-02-22 21:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070130091814.31530.23152.stgit@elm3a70.beaverton.ibm.com>
2007-01-30 9:18 ` [PATCH 01/12] sas_ata: Require CONFIG_ATA in Kconfig Darrick J. Wong
2007-01-30 9:18 ` [PATCH 02/12] sas_ata: Satisfy libata qc function locking requirements Darrick J. Wong
2007-01-30 9:18 ` [PATCH 03/12] sas_ata: sas_ata_qc_issue should return AC_ERR_* Darrick J. Wong
2007-01-30 9:18 ` [PATCH 04/12] sas_ata: ata_post_internal should abort the sas_task Darrick J. Wong
2007-02-07 7:47 ` Tejun Heo
2007-02-22 21:39 ` Darrick J. Wong [this message]
2007-02-22 21:43 ` [PATCH 1/2] sas_ata: Rename ata_queued_cmd->lldd_task to driver_data Jeff Garzik
2007-02-22 21:39 ` [PATCH 2/2]: sas_ata: Don't reset the phy in post_internal_command Darrick J. Wong
2007-01-30 9:18 ` [PATCH 05/12] sas_ata: Don't copy aic94xx's sactive to ata_port Darrick J. Wong
2007-01-30 9:18 ` [PATCH 06/12] sas_ata: Implement SATA PHY control Darrick J. Wong
2007-02-07 7:54 ` Tejun Heo
2007-01-30 9:18 ` [PATCH 07/12] libsas: Accept SAM_GOOD for ATAPI devices in sas_ata_task_done Darrick J. Wong
2007-01-30 9:18 ` [PATCH 08/12] libsas: Unknown STP devices should be reported to libata as unknown Darrick J. Wong
2007-02-07 8:20 ` Tejun Heo
2007-01-30 9:18 ` [PATCH 09/12] sas_ata: Assign sas_task to scsi_cmnd to enable EH for ATA devices Darrick J. Wong
2007-01-30 9:18 ` [PATCH 10/12] sas_ata: Implement sas_task_abort " Darrick J. Wong
2007-01-30 9:19 ` [PATCH 11/12] libsas: Provide a generic SATL registration function Darrick J. Wong
2007-01-30 9:19 ` [PATCH 12/12] sas_ata: Make this a module separate from libsas Darrick J. Wong
2007-02-03 16:03 ` James Bottomley
2007-02-04 9:06 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DE0DA9.7000200@us.ibm.com \
--to=djwong@us.ibm.com \
--cc=alexisb@us.ibm.com \
--cc=htejun@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox