Re: [PATCH] bsg: return SAM device status code

[Douglas Gilbert <dougg@torque.net>]

Pete Wyckoff wrote:
> Use the status codes from the standard, not the shifted-by-one codes
> that are marked deprecated in scsi.h.  This makes bsg v4 status
> report the same value as sg v3 status too.

Pete,
Good pick up. We certainly don't want to re-introduce
the SCSI status byte shift from the old days.

Doug Gilbert


> Signed-off-by: Pete Wyckoff <pw@osc.edu>
> ---
>  block/bsg.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/block/bsg.c b/block/bsg.c
> index c85d961..e39a321 100644
> --- a/block/bsg.c
> +++ b/block/bsg.c
> @@ -438,7 +438,7 @@ static int blk_complete_sgv4_hdr_rq(struct request *rq, struct sg_io_v4 *hdr,
>  	/*
>  	 * fill in all the output members
>  	 */
> -	hdr->device_status = status_byte(rq->errors);
> +	hdr->device_status = rq->errors & 0xff;
>  	hdr->transport_status = host_byte(rq->errors);
>  	hdr->driver_status = driver_byte(rq->errors);
>  	hdr->info = 0;