From: Douglas Gilbert <dougg@torque.net>
To: Mark Harvey <mark_harvey@symantec.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: bug or typo in scsi_debug.c
Date: Tue, 06 Mar 2007 09:22:54 -0500 [thread overview]
Message-ID: <45ED793E.9050200@torque.net> (raw)
In-Reply-To: <B3E98EAC5926D5498DDD341AE4B7D21CD5289C@TUS1XCHCLUPIN06.enterprise.veritas.com>
Mark Harvey wrote:
> Looking thru this driver, I saw what looks to be a bug/typo if an error
> occurs when
> calling driver_register() from scsi_debug_init()
>
> Cheers
> Mark
>
> --- scsi_debug-orig.c 2007-03-03 19:38:23.000000000 +1100
> +++ scsi_debug.c 2007-03-03 19:39:51.000000000 +1100
> @@ -2841,7 +2841,7 @@
> if (ret < 0) {
> printk(KERN_WARNING "scsi_debug: driver_register error:
> %d\n",
> ret);
> - goto bus_unreg;
> + goto driver_unreg;
> }
> ret = do_create_driverfs_files();
> if (ret < 0) {
> @@ -2873,6 +2873,7 @@
>
> del_files:
> do_remove_driverfs_files();
> +driver_unreg:
> driver_unregister(&sdebug_driverfs_driver);
> bus_unreg:
> bus_unregister(&pseudo_lld_bus);
Mark,
Um, I know my name is on that driver (with Eric's)
but I didn't write the code in that function.
I don't understand why your patch wants to call
driver_unregister() after driver_register() has failed.
Doug Gilbert
parent reply other threads:[~2007-03-06 14:23 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <B3E98EAC5926D5498DDD341AE4B7D21CD5289C@TUS1XCHCLUPIN06.enterprise.veritas.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ED793E.9050200@torque.net \
--to=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_harvey@symantec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).