Re: [PATCH v2 2/5] scsi: libsas: Simplify sas_ata_wait_eh()

[John Garry <john.g.garry@oracle.com>]

On 23/07/2025 09:51, Damien Le Moal wrote:
> Simplify the code of sas_ata_wait_eh(), removing the local variable ap
> for the pointer to the device ata_port structure.
> 
> No functional changes.
> 
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
 > --->   drivers/scsi/libsas/sas_ata.c | 9 ++-------
>   1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
> index 7b4e7a61965a..440efdc714f7 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -927,13 +927,8 @@ EXPORT_SYMBOL_GPL(sas_ata_schedule_reset);
>   
>   void sas_ata_wait_eh(struct domain_device *dev)
>   {
> -	struct ata_port *ap;
> -
> -	if (!dev_is_sata(dev))
> -		return;
> -
> -	ap = dev->sata_dev.ap;
> -	ata_port_wait_eh(ap);
> +	if (dev_is_sata(dev))

note that all callsites seem to check whether the dev is sata, so I 
wonder why even have that check?

other sas_ata.c function have the same pattern.


> +		ata_port_wait_eh(dev->sata_dev.ap);
>   }
>   
>   void sas_ata_device_link_abort(struct domain_device *device, bool force_reset)