public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian King <brking@us.ibm.com>
To: Ed Lin <ed.lin@promise.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"james.Bottomley" <james.Bottomley@SteelEye.com>,
	jeff <jeff@garzik.org>, promise_linux <promise_linux@promise.com>
Subject: Re: [PATCH 4/4] [SCSI]stex: minor cleanup and version update
Date: Mon, 02 Apr 2007 11:05:21 -0500	[thread overview]
Message-ID: <461129C1.30507@us.ibm.com> (raw)
In-Reply-To: <NONAMEBj81EYtN3Isam000005d6@nonameb.ptu.promise.com>

Ed Lin wrote:
> @@ -1007,6 +1008,11 @@ static int stex_abort(struct scsi_cmnd *
>  	u32 data;
>  	int result = SUCCESS;
>  	unsigned long flags;
> +
> +	printk(KERN_INFO DRV_NAME
> +		"(%s): aborting command\n", pci_name(hba->pdev));
> +	scsi_print_command(cmd);
> +

scmd_printk is probably what you want here rather than just a printk.

scmd_printk(KERN_ERR, cmd, "aborting command\n");


> @@ -1092,6 +1098,10 @@ static int stex_reset(struct scsi_cmnd *
>  	unsigned long before;
>  	hba = (struct st_hba *) &cmd->device->host->hostdata[0];
> 
> +	printk(KERN_INFO DRV_NAME
> +		"(%s): resetting host\n", pci_name(hba->pdev));
> +	scsi_print_command(cmd);
> +

Same here.

Brian

-- 
Brian King
eServer Storage I/O
IBM Linux Technology Center

  reply	other threads:[~2007-04-02 16:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-30 22:21 [PATCH 4/4] [SCSI]stex: minor cleanup and version update Ed Lin
2007-04-02 16:05 ` Brian King [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-04-02 18:21 Ed Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=461129C1.30507@us.ibm.com \
    --to=brking@us.ibm.com \
    --cc=ed.lin@promise.com \
    --cc=james.Bottomley@SteelEye.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=promise_linux@promise.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox