Re: [patch 1/1] scsi: Disable short inquiry log by default

[Brian King <brking@linux.vnet.ibm.com>]

James Bottomley wrote:
> On Mon, 2007-04-02 at 16:20 -0500, brking@linux.vnet.ibm.com wrote:
>> If a scsi device reports less than 36 bytes of standard inquiry
>> data, scsi core logs a KERN_INFO printk indicating this. It was
>> observed that this results in lots of clutter in the log on
>> systems with devices that respond to a SCSI Inquiry with PQ=3 or
>> PQ=1 with less than 36 bytes of inquiry data, such as ibmvscsi.
>> Disable this log by default.
> 
> It shouldn't be doing this ... the standards are pretty clear, say SPC-3
> section 6.4.2
> 
> "The standard INQUIRY data shall contain at least 36 bytes"
> 
> Horrible things happen when this rule is violated (as it is by some
> badly constructed devices), so I'd really like to leave the print in so
> we know what we're debugging.
> 
> Can't you fix ibmvscsi to be standards compliant?

James,

You can drop this patch. I've verified that the current ibmvscsi server
does not do this. I wasn't using the latest ibmvscsi server implementation.

Brian

-- 
Brian King
eServer Storage I/O
IBM Linux Technology Center