From: Mike Christie <michaelc@cs.wisc.edu>
To: David C Somayajulu <david.somayajulu@qlogic.com>
Cc: linux-scsi@vger.kernel.org, David Wagner <david.wagner@qlogic.com>
Subject: Re: [RFC] [PATCH 4/5] qla4xxx: Add IPv6 support and misc
Date: Mon, 07 May 2007 13:31:12 -0500 [thread overview]
Message-ID: <463F7070.5080601@cs.wisc.edu> (raw)
In-Reply-To: <1178158199.21709.5.camel@iscsi-sles10>
David C Somayajulu wrote:
> Signed-off-by: David Somayajulu <david.somayajulu@qlogic.com>
>
> ---
> drivers/scsi/qla4xxx/ql4_mbx.c | 190 ++++++++++------
>
> diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c
> index 7f28657..0ef777a 100644
> --- a/drivers/scsi/qla4xxx/ql4_mbx.c
> +++ b/drivers/scsi/qla4xxx/ql4_mbx.c
> @@ -6,6 +6,10 @@
> */
>
> #include "ql4_def.h"
> +#include "ql4_version.h"
> +#include "ql4_glbl.h"
> +#include "ql4_dbg.h"
> +#include "ql4_inline.h"
Did you need to bring in all of these? You did not need version did you?
>
> - memset((void *)fw_ddb_entry->iSCSIAlias, 0,
> - sizeof(fw_ddb_entry->iSCSIAlias));
> + memset((void *)fw_ddb_entry->iscsi_alias, 0,
> + sizeof(fw_ddb_entry->iscsi_alias));
>
> - memset((void *)fw_ddb_entry->iscsiName, 0,
> - sizeof(fw_ddb_entry->iscsiName));
> + memset((void *)fw_ddb_entry->iscsi_name, 0,
> + sizeof(fw_ddb_entry->iscsi_name));
>
> - memset((void *)fw_ddb_entry->ipAddr, 0, sizeof(fw_ddb_entry->ipAddr));
> - memset((void *)fw_ddb_entry->targetAddr, 0,
> - sizeof(fw_ddb_entry->targetAddr));
> + memset((void *)fw_ddb_entry->ip_addr, 0, sizeof(fw_ddb_entry->ip_addr));
> + memset((void *)fw_ddb_entry->tgt_addr, 0,
> + sizeof(fw_ddb_entry->tgt_addr));
>
I am not sure if it is a big deal or if it clutters the code, but I do
not think you need the void * casts in there.
next prev parent reply other threads:[~2007-05-07 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 2:09 [RFC] [PATCH 4/5] qla4xxx: Add IPv6 support and misc David C Somayajulu
2007-05-07 18:31 ` Mike Christie [this message]
2007-05-07 18:50 ` David Somayajulu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463F7070.5080601@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=david.somayajulu@qlogic.com \
--cc=david.wagner@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox