From: Robert Hancock <hancockr@shaw.ca>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Salyzyn, Mark" <mark_salyzyn@adaptec.com>,
James Bottomley <James.Bottomley@SteelEye.com>,
Aubrey Li <aubreylee@gmail.com>,
Christoph Lameter <clameter@sgi.com>,
Bernhard Walle <bwalle@suse.de>,
linux-scsi@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [scsi] Remove __GFP_DMA
Date: Wed, 23 May 2007 23:28:50 -0600 [thread overview]
Message-ID: <46552292.3090207@shaw.ca> (raw)
In-Reply-To: <fa.txrEcCPLxIukzeVBv7UG39WubcI@ifi.uio.no>
Alan Cox wrote:
> On Wed, 23 May 2007 15:17:08 -0400
> "Salyzyn, Mark" <mark_salyzyn@adaptec.com> wrote:
>
>> The 31 bit limit for some of these cards is a problem, we currently only
>> do __GFP_DMA for bounce buffer sg elements allocated for user supplied
>> references in ioctls.
>>
>> I figure we should be using pci_alloc_consistent calls for these
>> allocations to more accurately acquire memory within the 31 bit limit if
>> necessary, we could switch to these to remove the need for the __GFP_DMA
>> flag in the aacraid driver?
>
> That didn't used to work right on the AMD boards when I tried it last as
> we ended up with a buffer that was mapped by the IOMMU for some reason
> and that was not below 2GB.
The physical address you mean? If that is still happening then it needs
to get fixed. The allocation should not succeed if it can't provide
memory that's inside the DMA mask for the device..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/
next parent reply other threads:[~2007-05-24 5:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.6bUV4KR+za7HW4tT2WBlccqvoq0@ifi.uio.no>
[not found] ` <fa.NYl60pD1cwd1ESdKNCPaOwSz1WA@ifi.uio.no>
[not found] ` <fa.hW9tQQfgwmXj0gAKQoWXOxVzpvk@ifi.uio.no>
[not found] ` <fa.xLFpJ54sTvGq6YIol2Ew31Rrq2s@ifi.uio.no>
[not found] ` <fa.JZsPKKyEKOAfxp6reMY5ZwSNjQU@ifi.uio.no>
[not found] ` <fa.txrEcCPLxIukzeVBv7UG39WubcI@ifi.uio.no>
2007-05-24 5:28 ` Robert Hancock [this message]
2007-05-24 10:08 ` [PATCH] [scsi] Remove __GFP_DMA Alan Cox
2007-05-21 15:15 Bernhard Walle
2007-05-22 21:44 ` Christoph Lameter
2007-05-23 2:41 ` Aubrey Li
2007-05-23 15:18 ` James Bottomley
2007-05-23 15:55 ` Robert P. J. Day
2007-05-23 16:17 ` James Bottomley
2007-05-23 19:17 ` Salyzyn, Mark
2007-05-23 19:38 ` Alan Cox
2007-05-27 19:46 ` James Bottomley
2007-05-24 13:24 ` Salyzyn, Mark
2007-05-24 14:59 ` James Bottomley
2007-05-24 17:00 ` Christoph Lameter
2007-05-24 17:15 ` James Bottomley
2007-05-24 17:22 ` Christoph Lameter
2007-05-24 17:26 ` James Bottomley
2007-05-24 16:59 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46552292.3090207@shaw.ca \
--to=hancockr@shaw.ca \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=aubreylee@gmail.com \
--cc=bwalle@suse.de \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).