Re: cciss broken with 2.6.22-rc2

[Hannes Reinecke <hare@suse.de>]

Miller, Mike (OS Dev) wrote:
>  
> 
>> -----Original Message-----
>> From: Hannes Reinecke [mailto:hare@suse.de] 
>> Sent: Tuesday, May 29, 2007 7:01 AM
>> To: Miller, Mike (OS Dev); SCSI Mailing List
>> Subject: cciss broken with 2.6.22-rc2
>>
>> Hi Mike,
>>
>> with the latest git snapshot the cciss driver hangs during 
>> initialisation. Enabling debug output I get:
>>
>> cciss0: <0x3230> at PCI 0000:06:00.0 IRQ 4338 using DAC 
>> Sending cff0000 - down to controller
>> cciss:  FIFO Empty read
>> cciss:  Read cff00000 back from board
>> Sending cff0000 - down to controller
>> cciss:  FIFO Empty read
>> cciss:  Read cff00002 back from board
>> LUN Data
>> --------------------------
>> Sending cff0000 - down to controller
>> cciss:  FIFO Empty read
>> cciss:  Read cff00000 back from board
>>       blocks= 286677120 block_size= 512
>> Sending cff0000 - down to controller
>> cciss:  FIFO Empty read
>> cciss:  Read cff00002 back from board
>>       heads=255, sectors=32, cylinders=35132
>>
>> Sending 5103000 - down to controller
>>
>> and then the machine hangs.
>> I'll try to investigate, but as I'm no expert in cciss my 
>> results might be limited.
>> Looks like one of your recent fixes broke it; 2.6.21 worked fine.
> 
> Hannes,
> Actually, it was someone else who broke the driver by making changes
> in msi.c. This patch fixes the hang:
> 
> From: "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net> writes:
> 
> Found what seems the problem with our vectors being listed backward.
> In drivers/pci/msi.c we should be using list_add_tail rather than
> list_add to preserve the ordering across various kernels. Please
> consider this for inclusion.
> 
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
> 
> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 0e67723..d74975d 100644
[ .. ]
> 
> We found and fixed these late last week. So I hope they make into Linus' git tree ASAP.

Yes, these patches work.

Thanks,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html