From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: 2.6.22-rc3-mm1 Date: Thu, 31 May 2007 08:35:13 -0400 Message-ID: <465EC101.7010105@garzik.org> References: <20070530235823.793f00d9.akpm@linux-foundation.org> <20070531140922.2e55aefb@gondolin.boeblingen.de.ibm.com> <20070531121557.GQ23968@parisc-linux.org> <20070531142048.05edf133@gondolin.boeblingen.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:42877 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761304AbXEaMfu (ORCPT ); Thu, 31 May 2007 08:35:50 -0400 In-Reply-To: <20070531142048.05edf133@gondolin.boeblingen.de.ibm.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Cornelia Huck Cc: Matthew Wilcox , Andrew Morton , linux-kernel@vger.kernel.org, SCSI development list , James Bottomley , Dan Williams Cornelia Huck wrote: > On Thu, 31 May 2007 06:15:57 -0600, > Matthew Wilcox wrote: > >> On Thu, May 31, 2007 at 02:09:22PM +0200, Cornelia Huck wrote: >>> I split those functions out into a new file. Builds on s390 and i386. >> Why not just put #ifdef CONFIG_HAS_DMA / #endif around the pair of >> functions? I don't see the need to add a new Kconfig symbol and a new >> file for this. > > I prefer a new file over #ifdefs in c files. (New dma-dependent stuff > would also have a place where it could go to.) > > But I'll do whatever ends up as consensus :) 50 lines isn't much need for a new file. Jeff