From: Brian King <brking@linux.vnet.ibm.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: santil@linux.vnet.ibm.com, rcjenn@linux.vnet.ibm.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/5] ibmvscsi: Remove unnecessary map_sg check
Date: Thu, 14 Jun 2007 08:38:25 -0500 [thread overview]
Message-ID: <467144D1.1060309@linux.vnet.ibm.com> (raw)
In-Reply-To: <4670701E.2010404@garzik.org>
Jeff Garzik wrote:
> Brian King wrote:
>> Since sg_tablesize is set appropriately in the scsi host template,
>> remove the unnecessary check to make sure it is not exceeded
>> following the dma_map_sg call.
>>
>> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
>> ---
>>
>> linux-2.6-bjking1/drivers/scsi/ibmvscsi/ibmvscsi.c | 7 -------
>> 1 file changed, 7 deletions(-)
>
> Patches 1-5 look OK to me... modulo the question I just sent
Thanks for the review
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
next prev parent reply other threads:[~2007-06-14 13:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11817727312836-patch-mail.ibm.com>
2007-06-13 22:12 ` [PATCH 2/5] ibmvscsi: Enhanced error logging Brian King
2007-06-13 22:12 ` [PATCH 3/5] ibmvscsi: Add eh_host_reset_handler Brian King
2007-06-13 22:30 ` Jeff Garzik
2007-06-14 13:37 ` Brian King
2007-06-13 22:12 ` [PATCH 4/5] ibmvscsi: Misc. locking fixes Brian King
2007-06-13 22:12 ` [PATCH 5/5] ibmvscsi: Abort path fix Brian King
2007-06-13 22:30 ` [PATCH 1/5] ibmvscsi: Remove unnecessary map_sg check Jeff Garzik
2007-06-14 13:38 ` Brian King [this message]
2007-06-13 22:12 Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467144D1.1060309@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rcjenn@linux.vnet.ibm.com \
--cc=santil@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).