From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH 0/0] scsi_cmnd accessors issues Date: Sun, 17 Jun 2007 12:45:17 +0300 Message-ID: <467502AD.6090309@panasas.com> References: <466EDFAC.9020104@panasas.com> <20070613085118P.fujita.tomonori@lab.ntt.co.jp> <20070613194513H.fujita.tomonori@lab.ntt.co.jp> <46716C45.1090107@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from gw-e.panasas.com ([65.194.124.178]:44821 "EHLO cassoulet.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759690AbXFQJpm (ORCPT ); Sun, 17 Jun 2007 05:45:42 -0400 In-Reply-To: <46716C45.1090107@panasas.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: FUJITA Tomonori , Ed Lin , Guennadi Liakhovetski Cc: linux-scsi@vger.kernel.org Boaz Harrosh wrote: > FUJITA Tomonori wrote: >> There are just two llds. I suspect that we can fix them. Or they can >> access to the data directly (without the accessors) if we can't. >> >> I don't think that introducing something like scsi_set_sg_count, which >> is meaningless to most of llds, is a good idea. > > Following are 3 patches for fixing the l-value issues for accessors. > > 0/1 - proposed new accessors which will not let l-value code compile. > 0/2 - Clean fix of drivers/scsi/tmscsim.c to not need setting of sg_count > 0/3 - In drivers/scsi/stex.c open code of write access to request_bufflen. > when new code is committed this driver will have to change with it. > > > - > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Hi Tomo. I do not understand. - Do you not accept my first patch. This is to go in now for 2.6.23. It is for protection against out-of-tree and the rest of the not converted drivers. To not use new accessors as l-value. - Guennadi have you had a look at second patch it is clear that SavedSGCount is no longer used and that scsi_sg_count(pcmd) needs not be saved since it never changes. - Tomo, Ed. The 3rd patch was sent so the first patch can be accepted now. As stated, it is a fix to the first cleanup patch that wrongfully used scsi_bufflen as l-value. Boaz