From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: [PATCH 0/11] Take #2: Resurrect sdev during scanning
Date: Mon, 18 Jun 2007 11:00:45 +0200 [thread overview]
Message-ID: <467649BD.7040206@suse.de> (raw)
Hi James,
this is a rework of my earlier patchset to address the outstanding 'sdev
oops during scanning' issue. Problem is that any sdev in state
'SDEV_DEL' is still visible to the host until the refcount drops to
zero. When a scan occurs during this time we access a half-initialized
sdev and all hell breaks loose.
To address this issue this patchset expands the sdev state-machine to
allow a transition from SDEV_DEL back to SDEV_RUNNING. This is
implemented in the function scsi_resurrect_device(). So during scan we
only have to make sure to call scsi_resurrect_device() on all sdevs as
this will guarantee us that the sdev is operational during scanning.
In order to do so I reworked the sdev allocation and removal so that
we're more aligned with the sdev state machine and the driver core's
device_initialize / device_add logic.
Additionally I have expanded the state machine even more by introducing
a SDEV_NEW state, which will transition into SDEV_CREATED once
slave_alloc() is run. This will allow us to detect from within the
->release function whether slave_destroy() should be called.
With this we don't have to modify any LLDD, thus addressing the issue
hch had with the earlier patchset.
Comments etc. welcome.
Otherwise, please apply.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
reply other threads:[~2007-06-18 9:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467649BD.7040206@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).