Re: [PATCH 1/3] ufs: core: Fix ufshcd_mcq_force_compl_one()

["Peter Wang (王信友)" <peter.wang@mediatek.com>]

On Mon, 2026-03-30 at 11:33 -0700, Bart Van Assche wrote:
> There are two issues with the code in
> ufshcd_mcq_compl_all_cqes_lock():
> - The completion queue is processed without checking first whether it
> is
>   empty.
> 

Hi Bart,

Does ufshcd_mcq_compl_all_cqes_lock not check whether the CQ
is empty because there could be cases where the CQ is empty
but there are still ongoing requests?


> 
> @@ -5855,7 +5855,7 @@ static bool ufshcd_mcq_force_compl_one(struct
> request *rq, void *priv)
>         if (blk_mq_is_reserved_rq(rq) || !hwq)
>                 return true;
> 
> -       ufshcd_mcq_compl_all_cqes_lock(hba, hwq);
> +       ufshcd_mcq_poll_cqe_lock(hba, hwq);
> 
> 

Since ufshcd_mcq_force_compl_one and ufshcd_mcq_compl_one
are very similar, would it be possible to merge them into 
one function, with a parameter to handle the force completion
case?

Thanks.
Peter