[PATCH] scsi disk help file is not complete

[PATCH] scsi disk help file is not complete

[Randy Dunlap]

On Mon, 11 Jun 2007 20:28:16 +0200 api wrote:

> Good day,
> When doing make menuconfig one comes across CONFIG_BLK_DEV_SD.
> The help file states that this is for scsi disks.NO MENTION IS MADE THAT
> IT IS NEEDE FOR SATA DISKS AS WELL!
> Would have saved me a lot of time if the help was up to date.
> I hope this can be changed so others can make a kernel for sata systems
> quicker.


From: Randy Dunlap <randy.dunlap@oracle.com>

Add help info for BLK_DEV_SD referring to its use in
SATA or PATA driver configurations.

Add help text for "ATA" indicating that it probably needs
some SCSI config symbols enabled in order to be useful.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/ata/Kconfig  |    5 +++++
 drivers/scsi/Kconfig |    1 +
 2 files changed, 6 insertions(+)

--- linux-2622-rc4.orig/drivers/scsi/Kconfig
+++ linux-2622-rc4/drivers/scsi/Kconfig
@@ -60,6 +60,7 @@ config BLK_DEV_SD
 	depends on SCSI
 	---help---
 	  If you want to use SCSI hard disks, Fibre Channel disks,
+	  Serial ATA (SATA) or Parallel ATA (PATA) hard disks,
 	  USB storage or the SCSI or parallel port version of
 	  the IOMEGA ZIP drive, say Y and read the SCSI-HOWTO,
 	  the Disk-HOWTO and the Multi-Disk-HOWTO, available from
--- linux-2622-rc4.orig/drivers/ata/Kconfig
+++ linux-2622-rc4/drivers/ata/Kconfig
@@ -17,6 +17,11 @@ menuconfig ATA
 	  that "speaks" the ATA protocol, also called ATA controller),
 	  because you will be asked for it.
 
+	  NOTE: ATA enables basic SCSI support; *however*,
+	  'SCSI disk support', 'SCSI tape support', or
+	  'SCSI CDROM support' may also be needed,
+	  depending on your hardware configuration.
+
 if ATA
 
 config ATA_NONSTANDARD

Re: [PATCH] scsi disk help file is not complete

[Jeff Garzik]

Randy Dunlap wrote:
> On Mon, 11 Jun 2007 20:28:16 +0200 api wrote:
> 
>> Good day,
>> When doing make menuconfig one comes across CONFIG_BLK_DEV_SD.
>> The help file states that this is for scsi disks.NO MENTION IS MADE THAT
>> IT IS NEEDE FOR SATA DISKS AS WELL!
>> Would have saved me a lot of time if the help was up to date.
>> I hope this can be changed so others can make a kernel for sata systems
>> quicker.
> 
> 
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Add help info for BLK_DEV_SD referring to its use in
> SATA or PATA driver configurations.
> 
> Add help text for "ATA" indicating that it probably needs
> some SCSI config symbols enabled in order to be useful.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  drivers/ata/Kconfig  |    5 +++++
>  drivers/scsi/Kconfig |    1 +
>  2 files changed, 6 insertions(+)

applied