public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: "Salyzyn, Mark" <mark_salyzyn@adaptec.com>
Cc: linux-scsi@vger.kernel.org, jens.axboe@oracle.com
Subject: Re: [PATCH 2/2] blk request timeout handler:
Date: Mon, 09 Jul 2007 10:56:48 -0500	[thread overview]
Message-ID: <46925AC0.4020102@cs.wisc.edu> (raw)
In-Reply-To: <AE4F746F2AECFC4DA4AADD66A1DFEF01B8E0CC@otce2k301.adaptec.com>

I dropped Jen's old suse address and added his oracle one.

Salyzyn, Mark wrote:
> What ever happened to the following (admittedly snipped up) patch from a
> year ago, was there a reason this initiative was dropped? If so, please
> state what I missed?
> 

I have not worked on it because I got busy with iscsi again. I was 
trying to rework the patches, so that the scsi-ml would not have to do 
so much digging in the timers.

In the end I wanted it so the block layer started the timer when the 
command either was queued up or when it was sent to the LLD (I was not 
sure which was better), and the timer was stopped when the command was 
completed or when the LLD requeued it. The starting of the timer is 
easy, but with the stopping of it, scsi-ml needed to do some things like 
stop the timer manually then call a block layer requeue function and I 
wanted the block layer requeue function to stop the timer for scsi-ml so 
the LLD would not have to worry about it at all.

I also got stuck working out the details for situations like when we get 
into aborts and error handling and support for subsystems like DM or MD 
doing timers and stacking them on top of SCSI timers or having MD/DM 
timers calling into the SCSI timeout handlers.

  reply	other threads:[~2007-07-09 15:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-09 14:18 [PATCH 2/2] blk request timeout handler: Salyzyn, Mark
2007-07-09 15:56 ` Mike Christie [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-07-25  9:39 Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46925AC0.4020102@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=jens.axboe@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mark_salyzyn@adaptec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox