From: Jeff Garzik <jeff@garzik.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <jens.axboe@oracle.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: block/bsg.c
Date: Tue, 17 Jul 2007 19:37:53 -0400 [thread overview]
Message-ID: <469D52D1.1000803@garzik.org> (raw)
In-Reply-To: <1184710755.3378.30.camel@localhost.localdomain>
James Bottomley wrote:
> @@ -1052,9 +1054,10 @@ int generic_ide_ioctl(ide_drive_t *drive, struct file *file, struct block_device
> int err, (*setfunc)(ide_drive_t *, int);
> u8 *val;
>
> - err = scsi_cmd_ioctl(file, bdev->bd_disk->queue, bdev->bd_disk, cmd, p);
> - if (err != -ENOTTY)
> - return err;
> + switch (cmd) {
> + case SG_IO:
> + return scsi_cmd_ioctl(file, bdev->bd_disk->queue, bdev->bd_disk, cmd, p);
> + }
>
> switch (cmd) {
> case HDIO_GET_32BIT: val = &drive->io_32bit; goto read_val;
At that point you might as well use an 'if'.
But overall -- agreed. ACK.
Jeff
next prev parent reply other threads:[~2007-07-17 23:37 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 23:57 block/bsg.c Andrew Morton
2007-07-17 0:47 ` block/bsg.c Jeff Garzik
2007-07-17 0:53 ` block/bsg.c Andrew Morton
2007-07-17 0:58 ` block/bsg.c Jeff Garzik
2007-07-17 1:09 ` block/bsg.c Andrew Morton
2007-07-17 1:12 ` block/bsg.c Jeff Garzik
2007-07-17 1:47 ` block/bsg.c Jeff Garzik
2007-07-17 3:00 ` block/bsg.c Jeremy Fitzhardinge
2007-07-17 3:03 ` block/bsg.c Andrew Morton
2007-07-17 0:52 ` block/bsg.c Satyam Sharma
2007-07-17 0:57 ` block/bsg.c FUJITA Tomonori
2007-07-17 1:01 ` block/bsg.c Gabriel C
2007-07-17 4:57 ` block/bsg.c Joseph Fannin
2007-07-17 6:38 ` block/bsg.c Jens Axboe
2007-07-17 6:43 ` block/bsg.c FUJITA Tomonori
2007-07-17 6:59 ` block/bsg.c Jens Axboe
2007-07-17 7:08 ` block/bsg.c FUJITA Tomonori
2007-07-17 7:10 ` block/bsg.c Jens Axboe
2007-07-17 7:17 ` block/bsg.c FUJITA Tomonori
2007-07-17 7:19 ` block/bsg.c Jens Axboe
2007-07-17 10:07 ` block/bsg.c FUJITA Tomonori
2007-07-17 10:19 ` block/bsg.c Jens Axboe
2007-07-17 18:53 ` block/bsg.c James Bottomley
2007-07-17 19:48 ` block/bsg.c Andrew Morton
2007-07-17 19:52 ` block/bsg.c James Bottomley
2007-07-18 0:20 ` block/bsg.c FUJITA Tomonori
2007-07-18 13:54 ` block/bsg.c James Bottomley
2007-07-18 14:23 ` block/bsg.c James Bottomley
2007-07-18 23:18 ` block/bsg.c FUJITA Tomonori
2007-07-17 20:52 ` block/bsg.c Bartlomiej Zolnierkiewicz
2007-07-17 21:34 ` block/bsg.c Andrew Morton
2007-07-17 23:19 ` block/bsg.c Bartlomiej Zolnierkiewicz
2007-07-17 22:26 ` block/bsg.c FUJITA Tomonori
2007-07-18 20:39 ` block/bsg.c Bartlomiej Zolnierkiewicz
2007-07-18 23:44 ` block/bsg.c FUJITA Tomonori
2007-07-17 7:24 ` block/bsg.c FUJITA Tomonori
2007-07-17 19:18 ` block/bsg.c Andrew Morton
2007-07-17 20:22 ` block/bsg.c Andrew Morton
2007-07-17 22:19 ` block/bsg.c James Bottomley
2007-07-17 22:54 ` block/bsg.c Andrew Morton
2007-07-17 22:57 ` block/bsg.c James Bottomley
2007-07-17 23:37 ` Jeff Garzik [this message]
2007-07-18 0:43 ` block/bsg.c Bartlomiej Zolnierkiewicz
2007-07-18 14:11 ` block/bsg.c James Bottomley
2007-07-18 20:32 ` block/bsg.c Bartlomiej Zolnierkiewicz
2007-07-18 21:32 ` block/bsg.c James Bottomley
2007-07-17 7:48 ` block/bsg.c Jan Engelhardt
2007-07-17 12:04 ` [PATCH] Don't define empty struct bsg_class_device if !CONFIG_BLK_DEV_BSG (was: Re: block/bsg.c) Geert Uytterhoeven
2007-07-17 12:10 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469D52D1.1000803@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).