linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: "James Bottomley" <James.Bottomley@SteelEye.com>,
	"Christoph Hellwig" <hch@lst.de>,
	"Douglas Gilbert" <dougg@torque.net>,
	scsi <linux-scsi@vger.kernel.org>,
	"\"Jürgen E. Fischer\"" <fischer@norbit.de>,
	"FUJITA Tomonori" <fujita.tomonori@lab.ntt.co.jp>
Subject: Re: [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing
Date: Thu, 19 Jul 2007 18:57:50 +0300	[thread overview]
Message-ID: <469F89FE.4080900@panasas.com> (raw)
In-Reply-To: <20070719083719.33d8994c.rdunlap@xenotime.net>

Randy Dunlap wrote:
> 
> Yes, this problem has been around forever AFAIK.  You didn't add
> to it.
Do we need to file a bug report in Bugzilla or something, so people have a 
documentation of the work-around, until it is fixed?

I think that for now I will wrap it up as it is. Could you send me the right
BUG_ON() in place, with a printk pointing users to a solution? and I'll 
redo all the patches.

>>
>> One more thing if I may? Do you have at hand an old Zip cartridge that 
>> has bad sectors or other errors on it. My motivation is to exercise the
>> Sense return code-path. I would like to make sure that its doing the 
>> expected. It is the part that changed the most.
>> I will try to look if there is a way to send a scsi_read using sg3_utils that 
>> will read passed the media capacity, and will trigger a short read. I guess
>> on an unmounted device. Douglas?
> 
> No, I don't have any bad media that I know of.
> I suggest that you look into the "Fault-injection framework"
> (CONFIG_FAULT_INJECTION) to see if it can inject some errors for you.
> 
  Oh, I didn't realize there is one. OK nice I will look into it, thanks.
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***

Boaz

  reply	other threads:[~2007-07-19 15:58 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-12  9:42 [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing Boaz Harrosh
2007-07-12  9:49 ` [patch 1/4] aha152x.c - Preliminary fixes and some comments Boaz Harrosh
2007-07-12  9:55 ` [patch 2/4] aha152x.c - Clean Reset path Boaz Harrosh
2007-07-12 10:05 ` [patch 3/4] aha152x.c - Fix check_condition code-path Boaz Harrosh
2007-07-12 10:09 ` [patch 4/4] aha152x.c - use data accessors and !use_sg cleanup Boaz Harrosh
2007-07-12 13:17 ` [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing Boaz Harrosh
2007-07-12 20:57 ` Randy Dunlap
2007-07-16  9:22   ` Boaz Harrosh
2007-07-16  9:35     ` Christoph Hellwig
2007-07-18  0:16     ` Randy Dunlap
2007-07-18  9:29       ` Boaz Harrosh
2007-07-18 12:39         ` Boaz Harrosh
2007-07-18 17:33         ` Randy Dunlap
2007-07-18 21:58           ` Randy Dunlap
2007-07-19  2:43             ` Randy Dunlap
2007-07-19  3:03               ` Randy Dunlap
2007-07-19 13:04                 ` Boaz Harrosh
2007-07-19 15:37                   ` Randy Dunlap
2007-07-19 15:57                     ` Boaz Harrosh [this message]
2007-07-19 17:49                       ` Randy Dunlap
2007-07-24 10:12                         ` Boaz Harrosh
2007-07-24 16:17                           ` Randy Dunlap
2007-08-16  5:22                         ` Randy Dunlap
2007-08-16 14:39                           ` James Bottomley
2007-08-16 17:20                             ` Randy Dunlap
2007-08-16 17:18                               ` James Bottomley
2007-08-17 19:59                             ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469F89FE.4080900@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=dougg@torque.net \
    --cc=fischer@norbit.de \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).