Re: [PATCH 23/24] advansys: Improve interrupt handler

[Jeff Garzik <jeff@garzik.org>]

Matthew Wilcox wrote:
> On Fri, Jul 27, 2007 at 10:49:17AM -0400, Jeff Garzik wrote:
>> Matthew Wilcox wrote:
>>> Pass the Scsi_Host to the interrupt handler, rather than polling all
>>> hosts for each interrupt.
>>> Return IRQ_NONE if we didn't handle this interrupt
>>> Don't set the IRQF_DISABLED flag; this is not a fast-executing interrupt
>>> handler.
>>>
>>> Signed-off-by: Matthew Wilcox <matthew@wil.cx>
>> hrm.
>>
>> I thought you had multiple scsi hosts per board?  Thus multiple scsi 
>> hosts per interrupt?
> 
> Right.  We'll request the interrupt twice, each time with a different
> scsi_host.

ewwwwww.  That's, um, broken :)

I presume request_irq() will fail on non-ISA for subsequent calls, and 
your interrupt handler gets called -twice- for every single interrupt.