linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: "James Bottomley" <James.Bottomley@SteelEye.com>,
	"\"Jürgen E. Fischer\"" <fischer@norbit.de>,
	"FUJITA Tomonori" <fujita.tomonori@lab.ntt.co.jp>,
	linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path
Date: Tue, 31 Jul 2007 10:59:51 +0300	[thread overview]
Message-ID: <46AEEBF7.3060808@panasas.com> (raw)
In-Reply-To: <20070730171331.5237bb94.rdunlap@xenotime.net>

Randy Dunlap wrote:
> 
> Since you grok all of that (above), maybe you can help here:
> 
> With these 6 patches applied, I do the following:
> 
> 1.  insert PCMCIA aha152x card with SCSI drive attached (/dev/sdb4)
> 2.  mount -t vfat /dev/sdb4 /mnt/disk
> 3.  play with /mnt/disk
> 4.  umount /mnt/disk
> 
> Now I would like to rmmod the aha152x_cs module, but its use count
> is 2.  Even if I eject the card, its use count stays at 2.
> Maybe the reset or check_condition patch doesn't clean up correctly,
> or one of them isn't releasing a used resource ?
> 
> (this is 2.6.23-rc1 + your 6 patches + 1 acpi seq-file throttling fix.)
> 

I had an hard look and a very careful line-by-line compare
and I can't find anything obvious. Could you do a bisect.
maybe it will give me a clue as to where to look. Also please
Enable debug prints. Maybe the driver is stuck at some state 
and does not exit.

Thanks
Boaz




  reply	other threads:[~2007-07-31  8:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-29 19:10 [patch 0/6] aha152x.c - Cleanup, bugfixes, convert to accessors Boaz Harrosh
2007-07-29 19:16 ` [PATCH 1/6] aha152x.c - In debug mode Boaz Harrosh
2007-07-29 19:18 ` [PATCH 2/6] aha152x.c - use bounce buffer Boaz Harrosh
2007-07-29 19:22 ` [PATCH 3/6] aha152x.c - Preliminary fixes and some comments Boaz Harrosh
2007-07-29 19:24 ` [PATCH 4/6] aha152x.c - Clean Reset path Boaz Harrosh
2007-07-29 19:27 ` [PATCH 5/6] aha152x.c - Fix check_condition code-path Boaz Harrosh
2007-07-31  0:13   ` Randy Dunlap
2007-07-31  7:59     ` Boaz Harrosh [this message]
2007-07-31 17:08       ` Randy Dunlap
2007-07-31 18:40       ` Randy Dunlap
2007-08-01 13:51         ` James Bottomley
2007-08-01 16:34           ` Randy Dunlap
2007-08-02 11:26             ` Boaz Harrosh
2007-08-02 19:09               ` Randy Dunlap
2007-08-02 19:08                 ` James Bottomley
2007-08-02 20:22                 ` Jürgen E. Fischer
2007-08-02 22:47                 ` Randy Dunlap
2007-07-29 19:29 ` [PATCH 6/6] aha152x.c - use data accessors and !use_sg cleanup Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46AEEBF7.3060808@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=fischer@norbit.de \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).