* drivers/scsi/advansys.c compile error ( Re: 2.6.23-rc1-mm2 ) [not found] <20070731230932.a9459617.akpm@linux-foundation.org> @ 2007-08-01 13:01 ` Gabriel C 2007-08-01 13:39 ` [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error Eugene Teo 0 siblings, 1 reply; 7+ messages in thread From: Gabriel C @ 2007-08-01 13:01 UTC (permalink / raw) To: Andrew Morton; +Cc: linux-kernel, linux-scsi Getting this with a randconfig ( http://194.231.229.228/MM/randconfig-auto-10 ) ... drivers/scsi/advansys.c:794:2: warning: #warning this driver is still not properly converted to the DMA API drivers/scsi/advansys.c: In function 'advansys_board_found': drivers/scsi/advansys.c:17781: error: implicit declaration of function 'to_pci_dev' drivers/scsi/advansys.c:17781: warning: pointer/integer type mismatch in conditional expression drivers/scsi/advansys.c:17788: warning: unused variable 'pci_memory_address' drivers/scsi/advansys.c:17781: warning: unused variable 'pdev' make[2]: *** [drivers/scsi/advansys.o] Error 1 make[1]: *** [drivers/scsi] Error 2 make[1]: *** Waiting for unfinished jobs.... ... ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error 2007-08-01 13:01 ` drivers/scsi/advansys.c compile error ( Re: 2.6.23-rc1-mm2 ) Gabriel C @ 2007-08-01 13:39 ` Eugene Teo 2007-08-01 13:54 ` Gabriel C 2007-08-01 13:55 ` Matthew Wilcox 0 siblings, 2 replies; 7+ messages in thread From: Eugene Teo @ 2007-08-01 13:39 UTC (permalink / raw) To: Gabriel C; +Cc: Andrew Morton, linux-kernel, linux-scsi Hi Gabriel, Hope the following trivial patch helps. <quote sender="Gabriel C"> > Getting this with a randconfig ( http://194.231.229.228/MM/randconfig-auto-10 ) > [...] > drivers/scsi/advansys.c:794:2: warning: #warning this driver is still not properly converted to the DMA API > drivers/scsi/advansys.c: In function 'advansys_board_found': > drivers/scsi/advansys.c:17781: error: implicit declaration of function 'to_pci_dev' [...] This patch fixes the following compile error: drivers/scsi/advansys.c: In function 'advansys_board_found': drivers/scsi/advansys.c:17781: error: implicit declaration of function 'to_pci_dev' Signed-off-by: Eugene Teo <eugeneteo@kernel.sg> --- drivers/scsi/advansys.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 79c0b6e..908f02b 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c @@ -774,6 +774,7 @@ #include <linux/stat.h> #include <linux/spinlock.h> #include <linux/dma-mapping.h> +#include <linux/pci.h> #include <asm/io.h> #include <asm/system.h> ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error 2007-08-01 13:39 ` [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error Eugene Teo @ 2007-08-01 13:54 ` Gabriel C 2007-08-01 13:55 ` Matthew Wilcox 1 sibling, 0 replies; 7+ messages in thread From: Gabriel C @ 2007-08-01 13:54 UTC (permalink / raw) To: Eugene Teo; +Cc: Andrew Morton, linux-kernel, linux-scsi Eugene Teo wrote: > Hi Gabriel, Hi Eugene, > Hope the following trivial patch helps. Yes it does , thx. > > <quote sender="Gabriel C"> >> Getting this with a randconfig ( http://194.231.229.228/MM/randconfig-auto-10 ) >> > [...] >> drivers/scsi/advansys.c:794:2: warning: #warning this driver is still not properly converted to the DMA API >> drivers/scsi/advansys.c: In function 'advansys_board_found': >> drivers/scsi/advansys.c:17781: error: implicit declaration of function 'to_pci_dev' > [...] > > This patch fixes the following compile error: > > drivers/scsi/advansys.c: In function 'advansys_board_found': > drivers/scsi/advansys.c:17781: error: implicit declaration of function > 'to_pci_dev' > > Signed-off-by: Eugene Teo <eugeneteo@kernel.sg> > --- > drivers/scsi/advansys.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c > index 79c0b6e..908f02b 100644 > --- a/drivers/scsi/advansys.c > +++ b/drivers/scsi/advansys.c > @@ -774,6 +774,7 @@ > #include <linux/stat.h> > #include <linux/spinlock.h> > #include <linux/dma-mapping.h> > +#include <linux/pci.h> > > #include <asm/io.h> > #include <asm/system.h> > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error 2007-08-01 13:39 ` [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error Eugene Teo 2007-08-01 13:54 ` Gabriel C @ 2007-08-01 13:55 ` Matthew Wilcox 2007-08-01 14:27 ` Gabriel C 1 sibling, 1 reply; 7+ messages in thread From: Matthew Wilcox @ 2007-08-01 13:55 UTC (permalink / raw) To: Eugene Teo; +Cc: Gabriel C, Andrew Morton, linux-kernel, linux-scsi On Wed, Aug 01, 2007 at 09:39:12PM +0800, Eugene Teo wrote: > This patch fixes the following compile error: > > drivers/scsi/advansys.c: In function 'advansys_board_found': > drivers/scsi/advansys.c:17781: error: implicit declaration of function > 'to_pci_dev' Or just remove the ifdefs around the include ... which is done in this patch: http://www.kernel.org/pub/linux/kernel/people/willy/advansys-2007-07-30/0001-advansys-version-copyright-etc.txt I'd be interested in seeing the results of the randconfig trials on the driver with those 23 patches applied, but not particularly interested in the intermediate result. -- "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error 2007-08-01 13:55 ` Matthew Wilcox @ 2007-08-01 14:27 ` Gabriel C 2007-08-01 14:32 ` Matthew Wilcox 0 siblings, 1 reply; 7+ messages in thread From: Gabriel C @ 2007-08-01 14:27 UTC (permalink / raw) To: Matthew Wilcox; +Cc: Eugene Teo, Andrew Morton, linux-kernel, linux-scsi Matthew Wilcox wrote: > On Wed, Aug 01, 2007 at 09:39:12PM +0800, Eugene Teo wrote: >> This patch fixes the following compile error: >> >> drivers/scsi/advansys.c: In function 'advansys_board_found': >> drivers/scsi/advansys.c:17781: error: implicit declaration of function >> 'to_pci_dev' > > Or just remove the ifdefs around the include ... which is done in this > patch: > > http://www.kernel.org/pub/linux/kernel/people/willy/advansys-2007-07-30/0001-advansys-version-copyright-etc.txt > > I'd be interested in seeing the results of the randconfig trials on the > driver with those 23 patches applied, but not particularly interested in > the intermediate result. > I can do that on weekend. Are the patches meant for -mm or git head ? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error 2007-08-01 14:27 ` Gabriel C @ 2007-08-01 14:32 ` Matthew Wilcox 2007-08-01 14:46 ` Gabriel C 0 siblings, 1 reply; 7+ messages in thread From: Matthew Wilcox @ 2007-08-01 14:32 UTC (permalink / raw) To: Gabriel C; +Cc: Eugene Teo, Andrew Morton, linux-kernel, linux-scsi On Wed, Aug 01, 2007 at 04:27:15PM +0200, Gabriel C wrote: > Matthew Wilcox wrote: > > I'd be interested in seeing the results of the randconfig trials on the > > driver with those 23 patches applied, but not particularly interested in > > the intermediate result. > > I can do that on weekend. Thanks > Are the patches meant for -mm or git head ? They were developed against git head as of a few days ago. Here's a git tree, if that's easier for you: http://git.kernel.org/?p=linux/kernel/git/willy/advansys.git;a=shortlog -- "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error 2007-08-01 14:32 ` Matthew Wilcox @ 2007-08-01 14:46 ` Gabriel C 0 siblings, 0 replies; 7+ messages in thread From: Gabriel C @ 2007-08-01 14:46 UTC (permalink / raw) To: Matthew Wilcox; +Cc: Eugene Teo, Andrew Morton, linux-kernel, linux-scsi Matthew Wilcox wrote: > On Wed, Aug 01, 2007 at 04:27:15PM +0200, Gabriel C wrote: >> Matthew Wilcox wrote: >>> I'd be interested in seeing the results of the randconfig trials on the >>> driver with those 23 patches applied, but not particularly interested in >>> the intermediate result. >> I can do that on weekend. > > Thanks > >> Are the patches meant for -mm or git head ? > > They were developed against git head as of a few days ago. Here's a git > tree, if that's easier for you: > > http://git.kernel.org/?p=linux/kernel/git/willy/advansys.git;a=shortlog > Ach nice , yes is a lot easier to work with git. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-08-01 14:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20070731230932.a9459617.akpm@linux-foundation.org>
2007-08-01 13:01 ` drivers/scsi/advansys.c compile error ( Re: 2.6.23-rc1-mm2 ) Gabriel C
2007-08-01 13:39 ` [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error Eugene Teo
2007-08-01 13:54 ` Gabriel C
2007-08-01 13:55 ` Matthew Wilcox
2007-08-01 14:27 ` Gabriel C
2007-08-01 14:32 ` Matthew Wilcox
2007-08-01 14:46 ` Gabriel C
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).