* [RFC][PATCH] Coding style fix drivers/scsi/mvme147.c
@ 2007-08-01 15:17 Michal Piotrowski
2007-08-01 15:20 ` Matthew Wilcox
2007-08-01 15:26 ` Michal Piotrowski
0 siblings, 2 replies; 3+ messages in thread
From: Michal Piotrowski @ 2007-08-01 15:17 UTC (permalink / raw)
To: Andrew Morton, linux-scsi, LKML
Hi,
Coding style fix
Regards,
Michal
--
LOG
http://www.stardust.webpages.pl/log/
Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
--- linux-mm-clean/drivers/scsi/mvme147.c 2007-07-09 01:32:17.000000000 +0200
+++ linux-mm/drivers/scsi/mvme147.c 2007-08-01 17:14:39.000000000 +0200
@@ -13,7 +13,7 @@
#include "wd33c93.h"
#include "mvme147.h"
-#include<linux/stat.h>
+#include <linux/stat.h>
#define HDATA(ptr) ((struct WD33C93_hostdata *)((ptr)->hostdata))
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC][PATCH] Coding style fix drivers/scsi/mvme147.c
2007-08-01 15:17 [RFC][PATCH] Coding style fix drivers/scsi/mvme147.c Michal Piotrowski
@ 2007-08-01 15:20 ` Matthew Wilcox
2007-08-01 15:26 ` Michal Piotrowski
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2007-08-01 15:20 UTC (permalink / raw)
To: Michal Piotrowski; +Cc: Andrew Morton, linux-scsi, LKML
On Wed, Aug 01, 2007 at 05:17:15PM +0200, Michal Piotrowski wrote:
> -#include<linux/stat.h>
> +#include <linux/stat.h>
Why does this driver need stat.h at all?
--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC][PATCH] Coding style fix drivers/scsi/mvme147.c
2007-08-01 15:17 [RFC][PATCH] Coding style fix drivers/scsi/mvme147.c Michal Piotrowski
2007-08-01 15:20 ` Matthew Wilcox
@ 2007-08-01 15:26 ` Michal Piotrowski
1 sibling, 0 replies; 3+ messages in thread
From: Michal Piotrowski @ 2007-08-01 15:26 UTC (permalink / raw)
To: Michal Piotrowski; +Cc: Andrew Morton, linux-scsi, LKML
Michal Piotrowski pisze:
> Hi,
>
> Coding style fix
>
Christoph Hellwig:
"There is no reason at all for a scsi driver to include stat.h"
Regards,
Michal
--
LOG
http://www.stardust.webpages.pl/log/
Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
--- linux-mm-clean/drivers/scsi/mvme147.c 2007-07-09 01:32:17.000000000 +0200
+++ linux-mm/drivers/scsi/mvme147.c 2007-08-01 17:24:22.000000000 +0200
@@ -13,8 +13,6 @@
#include "wd33c93.h"
#include "mvme147.h"
-#include<linux/stat.h>
-
#define HDATA(ptr) ((struct WD33C93_hostdata *)((ptr)->hostdata))
static struct Scsi_Host *mvme147_host = NULL;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-01 15:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-01 15:17 [RFC][PATCH] Coding style fix drivers/scsi/mvme147.c Michal Piotrowski
2007-08-01 15:20 ` Matthew Wilcox
2007-08-01 15:26 ` Michal Piotrowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).