Re: [PATCH 4/8] lpfc 8.2.2 : Rework the lpfc_printf_log() macro

[James Smart <James.Smart@Emulex.Com>]

Sorry, Attempting to sync our pools with the variance of upstream is difficult.

Leave this patch 4 in place. I'll submit a patch shortly to address you concern
and get the 8.2.2 sources in line.

-- james s

Boaz Harrosh wrote:
> Big NACK
> 
> The code was converted to Accessors. look Here:
> 
>> -			lpfc_printf_log(phba, KERN_INFO, LOG_FCP,
>> -					"%d (%d):0717 FCP command x%x residual "
>> -					"underrun converted to error "
>> -					"Data: x%x x%x x%x\n",
>> -					phba->brd_no, vpi, cmnd->cmnd[0],
>> -					scsi_bufflen(cmnd),
>> -					scsi_get_resid(cmnd), cmnd->underflow);
>> +			lpfc_printf_vlog(vport, KERN_INFO, LOG_FCP,
>> +					 "0717 FCP command x%x residual "
>> +					 "underrun converted to error "
>> +					 "Data: x%x x%x x%x\n",
>> +					 cmnd->cmnd[0], cmnd->request_bufflen,
>> +					 scsi_get_resid(cmnd), cmnd->underflow);
> 
> you removed an scsi_bufflen(cmnd) and put cmnd->request_bufflen in its place.
> the scsi_get_resid(cmnd) you left as is.
> 
> Boaz Harrosh
>