From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Smart Subject: Re: [PATCH 44] drivers/scsi/lpfc/lpfc_debugfs.c: kmalloc + memset conversion to kcalloc Date: Fri, 03 Aug 2007 11:42:03 -0400 Message-ID: <46B34CCB.4070602@emulex.com> References: <200707311845.48807.m.kozlowski@tuxland.pl> <200707312025.45603.m.kozlowski@tuxland.pl> Reply-To: James.Smart@Emulex.Com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200707312025.45603.m.kozlowski@tuxland.pl> Sender: kernel-janitors-owner@vger.kernel.org To: Mariusz Kozlowski Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andrew Morton , linux-scsi@vger.kernel.org List-Id: linux-scsi@vger.kernel.org ACK -- james s Mariusz Kozlowski wrote: > Signed-off-by: Mariusz Kozlowski > > drivers/scsi/lpfc/lpfc_debugfs.c | 13809 -> 13716 (-93 bytes) > drivers/scsi/lpfc/lpfc_debugfs.o | 146124 -> 146124 (0 bytes) > > drivers/scsi/lpfc/lpfc_debugfs.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > --- linux-2.6.23-rc1-mm1-a/drivers/scsi/lpfc/lpfc_debugfs.c 2007-07-26 13:07:42.000000000 +0200 > +++ linux-2.6.23-rc1-mm1-b/drivers/scsi/lpfc/lpfc_debugfs.c 2007-07-31 14:11:24.000000000 +0200 > @@ -432,14 +432,11 @@ lpfc_debugfs_initialize(struct lpfc_vpor > if (!lpfc_debugfs_start_time) > lpfc_debugfs_start_time = jiffies; > > - vport->disc_trc = kmalloc( > - (sizeof(struct lpfc_disc_trc) * lpfc_debugfs_max_disc_trc), > - GFP_KERNEL); > + vport->disc_trc = kcalloc(lpfc_debugfs_max_disc_trc, > + sizeof(struct lpfc_disc_trc), GFP_KERNEL); > > if (!vport->disc_trc) > goto debug_failed; > - memset(vport->disc_trc, 0, > - (sizeof(struct lpfc_disc_trc) * lpfc_debugfs_max_disc_trc)); > > snprintf(name, sizeof(name), "discovery_trace"); > vport->debug_disc_trc = >