From: Jeremy Linton <jli@greshamstorage.com>
To: akpm@linux-foundation.org
Cc: James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org,
Mike Christie <michaelc@cs.wisc.edu>
Subject: Re: [patch 07/30] Incorrect SCSI transfer length computation from odd sized scsi_execute_async() transfers.
Date: Mon, 13 Aug 2007 10:10:13 -0500 [thread overview]
Message-ID: <46C07455.7000903@greshamstorage.com> (raw)
In-Reply-To: <200708102150.l7ALoaLm011335@imap1.linux-foundation.org>
akpm@linux-foundation.org wrote:
> From: Jeremy Linton <jli@greshamstorage.com>
>
> Any function which use scsi_execute_async() and transfers "odd" sized data
> that doesn't align correctly with the segment sizes may have its transfer
> length padded out to the closest segment size.
I would like to strongly suggest that Mike Christie's patch be used instead.
http://www.mail-archive.com/linux-scsi@vger.kernel.org/msg06032.html
I finally hit the case he was talking about (the block layer retries 0 length commands caused by a size mismatch) and
its ugly. I'm not really sure why my initial tests weren't hitting that case, I was trying to understand why some blocks
were getting an extra command generated while others weren't. Sufficient to say, his patch fixes both problems, the
incorrect transfer lengths and the extra 0 length transfer being generated.
next prev parent reply other threads:[~2007-08-13 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 21:50 [patch 07/30] Incorrect SCSI transfer length computation from odd sized scsi_execute_async() transfers akpm
2007-08-13 15:10 ` Jeremy Linton [this message]
2007-08-13 18:00 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C07455.7000903@greshamstorage.com \
--to=jli@greshamstorage.com \
--cc=James.Bottomley@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).