public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Smart <James.Smart@Emulex.Com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.scsi.org, tore@linepro.no
Subject: Re: [PATCH] add container release logic - update fc transport to utilize it
Date: Tue, 14 Aug 2007 15:26:05 -0400	[thread overview]
Message-ID: <46C201CD.4000907@emulex.com> (raw)
In-Reply-To: <1187119074.3393.30.camel@localhost.localdomain>

James Bottomley wrote:
> I'm afraid if you look at your solution, you'll see it still doesn't
> quite work:  If the next thing the user does after unloading lpfc is to
> unload the transport class, the module is blown away with potentially a
> live release callback to now freed code.

You're right...  Although, most don't as the transports are dependencies
for the LLDD's, and it's only the LLDDs they care about. But, point taken.

> Isn't a better way to handle it simply to give
> transport_container_unregister() the semantics everyone is expecting
> (i.e. to wait for everything to be tidied up and gone)?  That way none
> of the transport classes needs updating, and we don't have to handle the
> rather nasty release and unload races.

I was hoping you'd give some guidance. This area is black voodoo... :)

Sure - so are you suggesting that transport_container_unregister()
continually loop until successful ?  If not, what other kind of semantic
can we give it that we don't have to muck with the transport classes ?

-- james s



  reply	other threads:[~2007-08-14 19:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-14 18:27 [PATCH] add container release logic - update fc transport to utilize it James Smart
2007-08-14 19:17 ` James Bottomley
2007-08-14 19:26   ` James Smart [this message]
2007-08-14 19:39     ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46C201CD.4000907@emulex.com \
    --to=james.smart@emulex.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=linux-kernel@vger.scsi.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=tore@linepro.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox