Re: [RFC PATCH] SCSI: split Kconfig menu into two

Stefan Richter
2007-09-15T14:12:39Z

Adrian Bunk wrote:
> On Sat, Sep 15, 2007 at 03:20:06PM +0200, Stefan Richter wrote:
>> It still doesn't entirely clarify whether users need sd, sr, st, and
>> whether thy need sd for the disk with root filesystem.
>
> If you want to do it in a really perfect way, help texts aren't the
> solution. You'll have to make the options like CONFIG_BLK_DEV_SR no
> longer be user visible and select'ed through dummy options like e.g.:
...
> tristate "USB Mass Storage hard disk support"
> depends on USB_STORAGE
> select BLK_DEV_SD
...
> tristate "USB Mass Storage CD/DVD support"
> depends on USB_STORAGE
> select BLK_DEV_SR
...

Perfect is in the eye of the beholder. You would consequently have to
add such options into all menus which contain scsi low-level providers.

Also, one more question on whether CONFIG_SCSI ought to be 'select'ed:
Where do scsi-core options like CONFIG_SCSI_CONSTANTS go?
--
Stefan Richter
-=====-=-=== =--= -====