Re: [PATCH 0/4] more gdth patches for your amusement

[Boaz Harrosh <bharrosh@panasas.com>]

On Tue, Sep 25 2007 at 13:56 +0200, Matthew Wilcox <matthew@wil.cx> wrote:
> On Tue, Sep 25, 2007 at 11:51:13AM +0200, Boaz Harrosh wrote:
>> On top of that I have my own agenda of cleaning the !use_sg code paths and getting
>> rid of scsi_cmnd abuse, so there is also that.
> 
> This seems like a good time to post my own patch that removes the use of
> ->scsi_done from gdth.  I have a plan to remove the ->scsi_done() callback
> (drivers will simply call the scsi_done() function directly), and fixing
> the half-dozen drivers that override it is part of that.
> 
> I haven't looked at Christoph's, Jeff's or your patches yet, so this
> patch may be entirely worthless.  My goal with it was not to clean up
> the driver (though it does a little), but to get gdth out of the way of
> cleaning up scsi_cmnd.
> 
> commit 06142e2394d83929b8b25feab70caab47ddfb791
> Author: Matthew Wilcox <willy@linux.intel.com>
> Date:   Sat Sep 22 22:57:06 2007 -0400
> 
>     gdth: Make one abuse of scsi_cmnd less obvious
>     
>     Rather than having internal commands abuse scsi_done to call
>     gdth_scsi_done, have all the places that use to call scsi_done directly
>     call gdth_scsi_done, which now checks whether the command was internal,
>     and calls scsi_done if not.
>     
>     Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
> 
> diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
> index b20c188..8a6a5f8 100644
> --- 

Hi Matthew!
This patch looks grate, Thanks. It is very good for the direction
I'm going to. However it does have a smallish conflict with One
of Jeff's patches where he completely removes the 2.4.x support.

If it is OK with you I will add your patch to my patchset with your
Singed-off-by, minus the conflict?
 
Boaz