Re: [PATCH] gdth: Stop abusing ->done for internal commands

Matthew Wilcox
2007-09-25T17:33:38Z

On Tue, Sep 25, 2007 at 07:30:29PM +0200, Boaz Harrosh wrote:
> OK This is on top of the first patch that I will take care of,
> right? (http://www.spinics.net/lists/linux-scsi/msg19470.html)

That's right.

> Here 2 it will not merge with my patchset. So I'll take it off your hands
> and rebase it to mine.

Wonderful. Again, I don't care about this driver, just want it to not
break (more than it's already broken).

> In my patchset I have introduced a gdth_cmnd_priv. That is associated
> with every command and is put on cmnd->host_scribble, I than moved lots
> of abused Scp and other members to that new structure. I also put a
> simple boolean that states that these are Internal commands. So what
> is left of this patch is the:
> - scp->done = gdth_scsi_done;
> I will add that one line removal to your previous patch.

Excellent. Makes perfect sense.

> > Ah; I was basing this on linus + scsi-misc. I guess scsi_lib hadn't
> > been converted because I just took the code from there.
> Yes scsi_lib was not converted, but scsi.c was.

OK. I've converted that in my tree now, and fixed a small whitespace
error I introduced. I'll wait for more comments before posting a
replacement patch.

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."