Re: queued patches for SCSI for 2.6.24

FUJITA Tomonori
2007-09-26T02:12:54Z

On Tue, 25 Sep 2007 20:42:35 -0500
James Bottomley <James.Bottomley@SteelEye.com> wrote:

> On Wed, 2007-09-26 at 10:28 +0900, FUJITA Tomonori wrote:
> > On Tue, 25 Sep 2007 20:00:02 -0500
> > James Bottomley <James.Bottomley@SteelEye.com> wrote:
> >
> > > Andrew asked that I provide a status report of pending updates. The
> > > list is attached below. It's pretty much driver updates and minor bug
> > > fixes. The main functionality changes are Kay's sysfs updates and the
> > > shift of the ULD attachement towards the block prep function.
> >
> > Can we make new 'supporrted_mode' and 'active_mode' attributes look
> > better?
> >
> > http://marc.info/?l=linux-scsi&m=118991196128245&w=2
>
> Sure, but Jeff's suggestion was a good one to avoid me having to change
> hundreds of files. Could you roll it up and resubmit?

This can be cleanly applied to scsi-misc.

-
From: FUJITA Tomonori <tomof@acm.org>
Subject: [PATCH] set supported_mode to MODE_INITIATOR by default

This sets supported_mode to MODE_INITIATOR if a lld doesn't specify
supported_mode in scsi_host_template.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
---
drivers/scsi/hosts.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index adc9559..694015d 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -342,6 +342,10 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
shost->unchecked_isa_dma = sht->unchecked_isa_dma;
shost->use_clustering = sht->use_clustering;
shost->ordered_tag = sht->ordered_tag;
+
+ if (!sht->supported_mode)
+ sht->supported_mode = MODE_INITIATOR;
+
shost->active_mode = sht->supported_mode;

if (sht->max_host_blocked)
--
1.5.2.4