Re: queued patches for SCSI for 2.6.24

Jeff Garzik
2007-09-26T02:37:40Z

FUJITA Tomonori wrote:
> diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
> index adc9559..694015d 100644
> --- a/drivers/scsi/hosts.c
> +++ b/drivers/scsi/hosts.c
> @@ -342,6 +342,10 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
> shost->unchecked_isa_dma = sht->unchecked_isa_dma;
> shost->use_clustering = sht->use_clustering;
> shost->ordered_tag = sht->ordered_tag;
> +
> + if (!sht->supported_mode)
> + sht->supported_mode = MODE_INITIATOR;
> +
> shost->active_mode = sht->supported_mode;

I almost hesitate to speak up, after making the original suggestion, but:

Are there any const-ness worries for scsi_host_template, or plans for
the future? I do not see any other examples of the host template
members getting modified.

Perhaps this value should instead be mirrored in scsi_host, like many
others?

Jeff