Re: [PATCH 2/16] gdth: split out eisa probing

Jeff Garzik
2007-10-03T18:07:31Z

Christoph Hellwig wrote:
> On Wed, Oct 03, 2007 at 01:59:23PM -0400, Jeff Garzik wrote:
>> Come on. The patches were posted for comments, and Rolf commented.
>> Don't give him a hard time for a valid comment.
>
> Sorry, but these comments are utterly useless. It's not like we're doing
> anything related to dma mapping, but just moving some init code around.
> If we actually did a major change in how dma mapping is handled the comment
> would be apropinquate and a switchover should happen as part of the patch
> series.

A comment noting a useful improvement is always helpful, even if it
cannot be addressed immediately. Please don't push reviewers away.
That severely demotivates other reviewers, when they see such treatment.

We talked about this at the Kernel Summit.

Jeff