Re: [PATCH 15/16] gdth: Move members from SCp to gdth_cmndinfo, stage 2

Christoph Hellwig
2007-10-03T18:16:09Z

On Tue, Oct 02, 2007 at 08:02:45PM +0200, Rolf Eike Beer wrote:
> volatile here is probably nonsense. Either you need proper locking on this
> struct in case there may be side-effects between different callers or it's
> unneeded at all. This looks really suspicious:

Yes, it's most likely wrong. But for now there's a really huge plate
of patches already, and we'd rather keep behaviour similar. Once we've
managed to actually test this big pile we can move on to cleaning up things
like that. And I suspect part of the right solution will be to get rid
of this busy loop entirely.