Re: [PATCH 2/16] gdth: split out eisa probing

Rolf Eike Beer
2007-10-03T17:32:25Z

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

Christoph Hellwig wrote:
> On Tue, Oct 02, 2007 at 07:20:38PM +0200, Rolf Eike Beer wrote:
> > Same thing as in ISA patch: this is not PCI and we should not hide what
> > we're doing so dma_alloc_consistent(NULL, ...) is better IMHO.
>
> passing NULL is the documented way to deal with ISA/EISA devices with
> the old pci dma api. Any change to these APIs should be a different
> patch, and there's about 100 more important things in gdth right now.

It's not about passing NULL there. We need to do that. But we should call it
with NULL as argument and not with ha->pdev to make this obvious.

Eike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]