Re: [RFC 0/16] gdth combined patchset & call for testers

Jeff Garzik
2007-09-30T21:08:01Z

Boaz Harrosh wrote:
> [11/16] gdth: switch to modern scsi host registration - Christoph
> Christoph what is missing from here is the remove of the deprecated
> pci_find_device() call. Can I Just use pci_get_device() of the same signature
> or do I need to call some other pci_ members after that?

The driver needs to be converted to the "new" hotplug APIs.

The main pre-reqs are accomplished by your patches: the driver is using
the modern scsi hotplug API, and uses pointers for the adapter struct
rather than indices.

The final pre-req -- if your patches do not do this already -- is to
completely eliminate any global driver arrays, and make sure all
structures are allocated on a per-HBA basis.

Once this is done, conversion to ISA/EISA/PCI hotplug API is pretty
straightforward. Each of those three bus APIs are the same:
per-instance probe and remove functions, and (for PCI and sometimes
EISA) an id table. This is the reason why the ISA/EISA/PCI codes were
split out into separate functions, to prepare for this conversion.

Jeff