linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Resend [PATCH] qla1280: uses wrong failure path after failed pci_set_dma_mask
@ 2007-10-03 11:22 Johannes Dickgreber
  0 siblings, 0 replies; only message in thread
From: Johannes Dickgreber @ 2007-10-03 11:22 UTC (permalink / raw)
  To: linux-scsi

Hi

Sorry, I got no answer, so i resend.

I think there will be a wrong goto target after a failed
pci_set_dma_mask.

Please Check.

Signed-off-by: Johannes Dickgreber tanzy@gmx.de
---
--- qla1280.c.orig	2007-09-19 23:32:33 +0200
+++ qla1280.c	2007-09-19 23:58:46 +0200
@@ -4298,7 +4298,7 @@ qla1280_probe_one(struct pci_dev *pdev, 
 			printk(KERN_WARNING "scsi(%li): Unable to set a "
 			       "suitable DMA mask - aborting\n", ha->host_no);
 			error = -ENODEV;
-			goto error_free_irq;
+			goto error_put_host;
 		}
 	} else
 		dprintk(2, "scsi(%li): 64 Bit PCI Addressing Enabled\n",
@@ -4308,7 +4308,7 @@ qla1280_probe_one(struct pci_dev *pdev, 
 		printk(KERN_WARNING "scsi(%li): Unable to set a "
 		       "suitable DMA mask - aborting\n", ha->host_no);
 		error = -ENODEV;
-		goto error_free_irq;
+		goto error_put_host;
 	}
 #endif



Thanks

	tanzy

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-10-03 11:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-03 11:22 Resend [PATCH] qla1280: uses wrong failure path after failed pci_set_dma_mask Johannes Dickgreber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).