From: Jeff Garzik <jeff@garzik.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-scsi@vger.kernel.org, Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH 14/17] sym53c8xx: Get rid of IRQ_FMT and IRQ_PRM
Date: Fri, 05 Oct 2007 16:59:47 -0400 [thread overview]
Message-ID: <4706A5C3.6000005@garzik.org> (raw)
In-Reply-To: <11916141153666-git-send-email-matthew@wil.cx>
Matthew Wilcox wrote:
> @@ -1196,8 +1193,8 @@ static int sym_host_info(struct sym_hcb *np, char *ptr, off_t offset, int len)
> copy_info(&info, "Chip " NAME53C "%s, device id 0x%x, "
> "revision id 0x%x\n", np->s.chip_name,
> np->s.device->device, np->s.device->revision);
> - copy_info(&info, "At PCI address %s, IRQ " IRQ_FMT "\n",
> - pci_name(np->s.device), IRQ_PRM(np->s.device->irq));
> + copy_info(&info, "At PCI address %s, IRQ %d\n",
> + pci_name(np->s.device), np->s.device->irq);
> copy_info(&info, "Min. period factor %d, %s SCSI BUS%s\n",
> (int) (np->minsync_dt ? np->minsync_dt : np->minsync),
> np->maxwide ? "Wide" : "Narrow",
> @@ -1283,9 +1280,9 @@ static struct Scsi_Host * __devinit sym_attach(struct scsi_host_template *tpnt,
> unsigned long flags;
> struct sym_fw *fw;
>
> - printk(KERN_INFO "sym%d: <%s> rev 0x%x at pci %s irq " IRQ_FMT "\n",
> + printk(KERN_INFO "sym%d: <%s> rev 0x%x at pci %s irq %d\n",
> unit, dev->chip.name, pdev->revision, pci_name(pdev),
> - IRQ_PRM(pdev->irq));
> + pdev->irq);
>
> /*
> * Get the firmware for this chip.
NAK
The proper format string is '%u' because irq is unsigned
next prev parent reply other threads:[~2007-10-05 20:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-05 19:54 [PATCH 1/17] sym53c8xx: Work around 53c896 erratum Matthew Wilcox
2007-10-05 19:54 ` [PATCH 2/17] sym53c8xx: Use pci_dev irq number Matthew Wilcox
2007-10-05 20:51 ` Jeff Garzik
2007-10-05 19:55 ` [PATCH 3/17] sym53c8xx: Remove data_mapping and data_mapped Matthew Wilcox
2007-10-05 20:52 ` Jeff Garzik
2007-10-05 19:55 ` [PATCH 4/17] sym53c8xx: Remove unnecessary check in queuecommand Matthew Wilcox
2007-10-05 19:55 ` [PATCH 5/17] sym53c8xx: Don't disable interrupts in the interrupt handler Matthew Wilcox
2007-10-05 19:55 ` [PATCH 6/17] sym53c8xx: Stop overriding scsi_done Matthew Wilcox
2007-10-05 19:55 ` [PATCH 7/17] sym53c8xx: PCI Error Recovery support Matthew Wilcox
2007-10-05 20:54 ` Jeff Garzik
2007-10-05 19:55 ` [PATCH 8/17] sym53c8xx: Use pdev->revision Matthew Wilcox
2007-10-05 19:55 ` [PATCH 9/17] sym53c8xx: Remove ->device_id Matthew Wilcox
2007-10-05 19:55 ` [PATCH 10/17] sym53c8xx: Remove io_ws, mmio_ws and ram_ws elements Matthew Wilcox
2007-10-05 20:55 ` Jeff Garzik
2007-10-05 19:55 ` [PATCH 11/17] sym53c8xx: Remove tag_ctrl module parameter Matthew Wilcox
2007-10-05 20:56 ` Jeff Garzik
2007-10-09 15:35 ` Matthew Wilcox
2007-10-05 19:55 ` [PATCH 12/17] sym53c8xx: Simplify DAC DMA handling Matthew Wilcox
2007-10-05 19:55 ` [PATCH 13/17] sym53c8xx: Use scmd_printk where appropriate Matthew Wilcox
2007-10-05 20:59 ` Jeff Garzik
2007-10-05 19:55 ` [PATCH 14/17] sym53c8xx: Get rid of IRQ_FMT and IRQ_PRM Matthew Wilcox
2007-10-05 20:59 ` Jeff Garzik [this message]
2007-10-09 15:28 ` Matthew Wilcox
2007-10-09 15:35 ` Jeff Garzik
2007-10-09 15:44 ` Matthew Wilcox
2007-10-09 15:47 ` Jeff Garzik
2007-10-05 19:55 ` [PATCH 15/17] sym53c8xx: Make interrupt handler capable of returning IRQ_NONE Matthew Wilcox
2007-10-05 21:04 ` Jeff Garzik
2007-10-05 19:55 ` [PATCH 16/17] sym53c8xx: Remove pci_dev pointer from sym_shcb Matthew Wilcox
2007-10-05 21:07 ` Jeff Garzik
2007-10-09 15:27 ` Matthew Wilcox
2007-10-05 19:55 ` [PATCH 17/17] sym53c8xx: Remove sym_xpt_async_sent_bdr Matthew Wilcox
2007-10-05 21:07 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4706A5C3.6000005@garzik.org \
--to=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).