From: Boaz Harrosh <bharrosh@panasas.com>
To: James Bottomley <James.Bottomley@SteelEye.com>,
"David S. Miller" <davem@davemloft.net>,
Matthew Wilcox <matthew@wil.cx>,
Andrew Morton <akpm@linux-foundation.org>linux-scsi <linux>
Cc: FUJITA Tomonori <tomof@acm.org>
Subject: [PATCHSET 0/3] pluto/fc - some fixes and cleanups
Date: Mon, 15 Oct 2007 19:20:53 +0200 [thread overview]
Message-ID: <4713A175.9020408@panasas.com> (raw)
I'm sending a small lift-up to the drivers/scsi/pluto.c and
drivers/fc4/fc.c pair, that where a bit stepped on lately.
Matthew this includes your patch, I just fixed up the patch
comment, since You had a good comment on the first patch
but sent a better second patch with no comment. (And my set
depends on yours so just to make sure.)
This is only compile tested, and from patch 3/3 below the
driver is in grate need of testers.
[patch 1/3] pluto/fc - Remove uses of the scsi_cmnd ->done
This is Matthew's patch with right commit-log inline?
[patch 2/3] pluto/fc - Enable compilation for all ARCHs
I'm not sure if the final verdict was yes on this one,
but it's what I needed in order to compile this.
[patch 3/3] pluto/fc - fix INQUIRY still using !use_sg commands
So this is broken and, can some body explain to me how this was
checked, because it looks to me that it should surely crash
terribly. pluto.c would send use_sg == 0 command on detection
but fc.c was already converted.
What this patch does is effectively reverts some of Tomo's
!use_sg cleanup, but only for the INQUIRY command that is
issued internally by pluto.c. (Sorry)
Happy testing
Boaz
next reply other threads:[~2007-10-15 17:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 17:20 Boaz Harrosh [this message]
2007-10-15 17:25 ` [PATCH 1/3] pluto/fc - Remove uses of the scsi_cmnd->done Boaz Harrosh
2007-10-15 17:56 ` Matthew Wilcox
2007-10-15 17:26 ` [PATCH 2/3] pluto/fc - Enable compilation for all ARCHs Boaz Harrosh
2007-10-15 18:09 ` Matthew Wilcox
2007-10-15 18:18 ` Boaz Harrosh
2007-10-15 18:39 ` Matthew Wilcox
2007-10-15 20:15 ` [PATCH 1/2] fc4/pluto " Randy Dunlap
2007-10-16 7:43 ` Boaz Harrosh
2007-10-15 20:16 ` [PATCH 2/2] pluto fix disable/enable irq Randy Dunlap
2007-10-15 17:34 ` [PATCH 3/3] pluto/fc - fix INQUIRY still using !use_sg commands Boaz Harrosh
2007-10-15 18:00 ` [PATCH 3/3 ver2] " Boaz Harrosh
2007-10-15 18:12 ` Matthew Wilcox
2007-10-15 18:32 ` [PATCH 3/3 ver3] " Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4713A175.9020408@panasas.com \
--to=bharrosh@panasas.com \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=matthew@wil.cx \
--cc=tomof@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).