From: Seokmann Ju <seokmann.ju@qlogic.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-scsi@vger.kernel.org, Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH 3/4] qla1280,qla2xxx: Remove display of transfersize
Date: Thu, 18 Oct 2007 14:05:21 -0700 [thread overview]
Message-ID: <4717CA91.7030407@qlogic.com> (raw)
In-Reply-To: <20071018201052.GA25831@parisc-linux.org>
Matthew Wilcox wrote:
> On Thu, Oct 18, 2007 at 11:57:33AM -0700, Seokmann Ju wrote:
>> Matthew Wilcox wrote:
>>> As part of their debug routines, both of these drivers print out the
>>> transfersize. That's just unnecessary, particularly since neither driver
>>> actually uses it.
>> NACK for qla2xxx - I would rather change it to 'cmd->device->sector_size' instead of removing it.
>> A patch will be followed by.
>
> I don't understand why you care to print it at this point. If you know
> the device, you know the sector size, right?
As the debug message doesn't get displayed in normal situation, just wanted to keep as many information in the function as possible.
Acked-by: Seokmann Ju <seokmann.ju@qlogic.com>
Thank you,
Seokmann
next prev parent reply other threads:[~2007-10-18 21:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 16:27 [PATCH 1/4] scsi_cmnd: Rearrange and shrink some elements Matthew Wilcox
2007-10-18 16:27 ` [PATCH 2/4] shuttle_usbat: Eliminate use of transfersize Matthew Wilcox
2007-10-18 16:27 ` [PATCH 3/4] qla1280,qla2xxx: Remove display " Matthew Wilcox
2007-10-18 18:57 ` Seokmann Ju
2007-10-18 20:10 ` Matthew Wilcox
2007-10-18 21:05 ` Seokmann Ju [this message]
2007-10-18 21:40 ` Matthew Wilcox
2007-10-18 16:27 ` [PATCH 4/4] Replace scmd->transfersize with scsi_transfer_size() Matthew Wilcox
2007-10-19 17:45 ` Stefan Richter
-- strict thread matches above, loose matches on Subject: below --
2007-10-18 8:46 [PATCH 1/4] scsi_cmnd: Rearrange and shrink some elements Matthew Wilcox
2007-10-18 8:46 ` [PATCH 3/4] qla1280,qla2xxx: Remove display of transfersize Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4717CA91.7030407@qlogic.com \
--to=seokmann.ju@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).