linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Matthew Wilcox <matthew@wil.cx>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/4] aic7xxx: Enable 16-bit CDBs
Date: Mon, 22 Oct 2007 08:50:45 +0200	[thread overview]
Message-ID: <471C4845.20708@suse.de> (raw)
In-Reply-To: <20071022034605.GB8421@parisc-linux.org>

Matthew Wilcox wrote:
> On Sun, Oct 21, 2007 at 11:19:22AM -0500, James Bottomley wrote:
>> But, I suppose the main point is: is this really necessary?  The
>> default, when unspecified, is 16 bytes and the mid-layer can't deliver
>> anything larger.  I would anticipate the large CDB infrastructure will
>> have some separate enabling, so why not simply do nothing until that
>> gets merged?
> 
> You're sadly mistaken ... the default is 12 byte cdbs:
> 
>         shost->max_cmd_len = 12;
> 
That's what I thought, too. Hence the patch.
But if we set the default to 16 byte cdbs you can of course ignore
the patch.

Cheers,

Hannes

-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2007-10-22  6:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-19  8:32 [PATCH 4/4] aic7xxx: Enable 16-bit CDBs Hannes Reinecke
2007-10-21 16:19 ` James Bottomley
2007-10-22  3:46   ` Matthew Wilcox
2007-10-22  6:50     ` Hannes Reinecke [this message]
2007-10-22 11:23       ` Matthew Wilcox
2007-10-22 11:57         ` Hannes Reinecke
2007-10-23 16:56           ` James Bottomley
2007-10-25  6:31             ` Hannes Reinecke
2007-10-22 19:10   ` Boaz Harrosh
2007-10-22 19:35     ` Matthew Wilcox
2007-10-22 21:24       ` Benny Halevy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471C4845.20708@suse.de \
    --to=hare@suse.de \
    --cc=James.Bottomley@SteelEye.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).