From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 1/4] [SCSI] ips: remove ips_ha members that duplicate struct pci_dev members Date: Thu, 25 Oct 2007 01:09:50 -0400 Message-ID: <4720251E.1030206@garzik.org> References: <09821349085390234lkjasdflkjasflkdj24746@havoc.gtf.org> <20071024234827.74AD61F81A1@havoc.gtf.org> <20071024212710.ae6e5120.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:49843 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbXJYFJw (ORCPT ); Thu, 25 Oct 2007 01:09:52 -0400 In-Reply-To: <20071024212710.ae6e5120.akpm@linux-foundation.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Andrew Morton Cc: LKML , linux-scsi@vger.kernel.org Andrew Morton wrote: > On Wed, 24 Oct 2007 19:48:26 -0400 (EDT) Jeff Garzik wrote: > >> drivers/scsi/ips.c | 178 ++++++++++++++++++++++++---------------------------- > > this driver seems a bit of a basket case :( > > > What's going on here? > > scb->dcdb.cmd_attribute = > ips_command_direction[scb->scsi_cmd->cmnd[0]]; > > /* Allow a WRITE BUFFER Command to Have no Data */ > /* This is Used by Tape Flash Utilites */ > if ((scb->scsi_cmd->cmnd[0] == WRITE_BUFFER) && (scb->data_len == 0)) > scb->dcdb.cmd_attribute = 0; > > if (!(scb->dcdb.cmd_attribute & 0x3)) > scb->dcdb.transfer_length = 0; > > if (scb->data_len >= IPS_MAX_XFER) { > > I hope that's just busted indentation and not a missing {} block. The driver is one of the grotty drivers people are afraid to touch, therefore it bitrots even faster, in a vicious cycle. You don't have to look hard at all to find checkpatch pukeage, very real bugs, and Pythonesque silliness. Not having hardware I went only for changes that are provable and obvious, really... Jeff