Re: [PATCH 4/4] aic7xxx: Enable 16-bit CDBs

[Hannes Reinecke <hare@suse.de>]

James Bottomley wrote:
> On Mon, 2007-10-22 at 13:57 +0200, Hannes Reinecke wrote:
>> Matthew Wilcox wrote:
>>> On Mon, Oct 22, 2007 at 08:50:45AM +0200, Hannes Reinecke wrote:
>>>> That's what I thought, too. Hence the patch.
>>>> But if we set the default to 16 byte cdbs you can of course ignore
>>>> the patch.
>>> I think the comment in hosts.c explains why we shouldn't do that ...
>>>
>> _I_ certainly wouldn't. But if the maintainer says so :-)
> 
> Actually, I misremembered.  I thought I did a commit a few years ago
> that automatically raised the cutoff to 16 byte cdbs and forced drivers
> who couldn't do that to lower the limit, but apparently it was never
> merged.
> 
> So, just pick either 16 or 32 for both drivers and add that as the max
> cdb size.
> 
Hmm. But aic7xxx actually supports 32-byte cdbs (for whatever reason);
cf drivers/scsi/aic7xxx/aic7xxx.h:478.
And aic79xx only supports 16 byte cdbs; the clever 'use pointer for cdb
if it's longer than the 12 bytes' routine sadly isn't implemented
for aic79xx.

It somehow feels wrong to arbitrarily cut the limit to 16 bytes for
aic7xxx, hence the two different limits.

But again, you're the maintainer, you get to decide.
If you feel it's reasonable to limit both to 16 byte so be it.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html