[PATCH] Remove #warnings for longstanding conditions.

[PATCH] Remove #warnings for longstanding conditions.

[Jeff Garzik]

These two warnings...

drivers/isdn/capi/capidrv.c:2126:3: warning: #warning FIXME: maybe a
race condition the card should be removed here from global list /kkeil

drivers/scsi/advansys.c:71:2: warning: #warning this driver is still
not properly converted to the DMA API

...represent conditions that have existed for years, and are duly noted
in FIXMEs.  There does not seem to be much need to warn on every kernel
build for a driver bug or handicap that has existed for years.

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
 drivers/isdn/capi/capidrv.c |    3 ++-
 drivers/scsi/advansys.c     |    1 -
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c
index 476012b..44f954d 100644
--- a/drivers/isdn/capi/capidrv.c
+++ b/drivers/isdn/capi/capidrv.c
@@ -2123,7 +2123,8 @@ static int capidrv_delcontr(u16 contr)
 		printk(KERN_ERR "capidrv: delcontr: no contr %u\n", contr);
 		return -1;
 	}
-	#warning FIXME: maybe a race condition the card should be removed here from global list /kkeil
+
+	/* FIXME: maybe a race condition the card should be removed here from global list /kkeil */
 	spin_unlock_irqrestore(&global_lock, flags);
 
 	del_timer(&card->listentimer);
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 9dd3952..e13e3a8 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -68,7 +68,6 @@
  *  7. advansys_info is not safe against multiple simultaneous callers
  *  8. Add module_param to override ISA/VLB ioport array
  */
-#warning this driver is still not properly converted to the DMA API
 
 /* Enable driver /proc statistics. */
 #define ADVANSYS_STATS
-- 
1.5.2.4

Re: [PATCH] Remove #warnings for longstanding conditions.

[Karsten Keil]

On Thu, Oct 25, 2007 at 04:06:15AM -0400, Jeff Garzik wrote:
> These two warnings...
> 
> drivers/isdn/capi/capidrv.c:2126:3: warning: #warning FIXME: maybe a
> race condition the card should be removed here from global list /kkeil
> 
> drivers/scsi/advansys.c:71:2: warning: #warning this driver is still
> not properly converted to the DMA API
> 
> ...represent conditions that have existed for years, and are duly noted
> in FIXMEs.  There does not seem to be much need to warn on every kernel
> build for a driver bug or handicap that has existed for years.
> 
> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
> ---
>  drivers/isdn/capi/capidrv.c |    3 ++-

Acked.

-- 
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)

Re: [PATCH] Remove #warnings for longstanding conditions.

[Matthew Wilcox]

On Thu, Oct 25, 2007 at 04:06:15AM -0400, Jeff Garzik wrote:
> drivers/scsi/advansys.c:71:2: warning: #warning this driver is still
> not properly converted to the DMA API
> 
> ...represent conditions that have existed for years, and are duly noted
> in FIXMEs.  There does not seem to be much need to warn on every kernel
> build for a driver bug or handicap that has existed for years.

I'll be removing this #warning from advansys when I get rid of the
last bus_to_virt.  Which I've already done ... it's just that the
resulting driver works on i386, but crashes parisc, so there's clearly a
bug.  I haven't had time to track it down yet.  So NACK this patch.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

Re: [PATCH] Remove #warnings for longstanding conditions.

[Jeff Garzik]

Matthew Wilcox wrote:

>> drivers/scsi/advansys.c:71:2: warning: #warning this driver is still
>> not properly converted to the DMA API

> I'll be removing this #warning from advansys when I get rid of the
> last bus_to_virt.  Which I've already done ... it's just that the
> resulting driver works on i386, but crashes parisc, so there's clearly a
> bug.  I haven't had time to track it down yet.  So NACK this patch.

Well, two main questions...

Is this warning of value to anybody but you?
Is this information worth printing out on everyone else's kernel build?

If yes, great!  But it sounds like this warning is analagous to

   #warning willy's TODO list: get milk, buy groceries, read email, ...

which doesn't add much value to others' kernel builds :)

	Jeff

Re: [PATCH] Remove #warnings for longstanding conditions.

[Matthew Wilcox]

On Thu, Oct 25, 2007 at 10:07:17PM -0400, Jeff Garzik wrote:
> Is this warning of value to anybody but you?

Yup.  It signals this driver isn't production quality yet.

> Is this information worth printing out on everyone else's kernel build?

I thnk that's worth noting to anyone who's enabled it.

> If yes, great!  But it sounds like this warning is analagous to
> 
>   #warning willy's TODO list: get milk, buy groceries, read email, ...
> 
> which doesn't add much value to others' kernel builds :)

I didn't add the #warning; it was there before 2.6.12-rc2.  I haven't
added warnings for anything else on the todo list (which remains
mightily long, but I'm acually crossing things off it rather than just
adding to it now).

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

Re: [PATCH] Remove #warnings for longstanding conditions.

[Jeff Garzik]

Matthew Wilcox wrote:
> On Thu, Oct 25, 2007 at 10:07:17PM -0400, Jeff Garzik wrote:
>> Is this warning of value to anybody but you?
> 
> Yup.  It signals this driver isn't production quality yet.
> 
>> Is this information worth printing out on everyone else's kernel build?
> 
> I thnk that's worth noting to anyone who's enabled it.

OK, thanks!

	Jeff