* [PATCH] Remove #warnings for longstanding conditions. [not found] <a576b5944eb04a18d4df3dd27cd32e7f13601470.1193299380.git.jeff@garzik.org> @ 2007-10-25 8:06 ` Jeff Garzik 2007-10-25 9:52 ` Karsten Keil 2007-10-25 11:22 ` Matthew Wilcox 0 siblings, 2 replies; 6+ messages in thread From: Jeff Garzik @ 2007-10-25 8:06 UTC (permalink / raw) To: LKML, linux-scsi; +Cc: akpm, willy, kkeil These two warnings... drivers/isdn/capi/capidrv.c:2126:3: warning: #warning FIXME: maybe a race condition the card should be removed here from global list /kkeil drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not properly converted to the DMA API ...represent conditions that have existed for years, and are duly noted in FIXMEs. There does not seem to be much need to warn on every kernel build for a driver bug or handicap that has existed for years. Signed-off-by: Jeff Garzik <jgarzik@redhat.com> --- drivers/isdn/capi/capidrv.c | 3 ++- drivers/scsi/advansys.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c index 476012b..44f954d 100644 --- a/drivers/isdn/capi/capidrv.c +++ b/drivers/isdn/capi/capidrv.c @@ -2123,7 +2123,8 @@ static int capidrv_delcontr(u16 contr) printk(KERN_ERR "capidrv: delcontr: no contr %u\n", contr); return -1; } - #warning FIXME: maybe a race condition the card should be removed here from global list /kkeil + + /* FIXME: maybe a race condition the card should be removed here from global list /kkeil */ spin_unlock_irqrestore(&global_lock, flags); del_timer(&card->listentimer); diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 9dd3952..e13e3a8 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c @@ -68,7 +68,6 @@ * 7. advansys_info is not safe against multiple simultaneous callers * 8. Add module_param to override ISA/VLB ioport array */ -#warning this driver is still not properly converted to the DMA API /* Enable driver /proc statistics. */ #define ADVANSYS_STATS -- 1.5.2.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Remove #warnings for longstanding conditions. 2007-10-25 8:06 ` [PATCH] Remove #warnings for longstanding conditions Jeff Garzik @ 2007-10-25 9:52 ` Karsten Keil 2007-10-25 11:22 ` Matthew Wilcox 1 sibling, 0 replies; 6+ messages in thread From: Karsten Keil @ 2007-10-25 9:52 UTC (permalink / raw) To: Jeff Garzik; +Cc: LKML, linux-scsi, akpm, willy On Thu, Oct 25, 2007 at 04:06:15AM -0400, Jeff Garzik wrote: > These two warnings... > > drivers/isdn/capi/capidrv.c:2126:3: warning: #warning FIXME: maybe a > race condition the card should be removed here from global list /kkeil > > drivers/scsi/advansys.c:71:2: warning: #warning this driver is still > not properly converted to the DMA API > > ...represent conditions that have existed for years, and are duly noted > in FIXMEs. There does not seem to be much need to warn on every kernel > build for a driver bug or handicap that has existed for years. > > Signed-off-by: Jeff Garzik <jgarzik@redhat.com> > --- > drivers/isdn/capi/capidrv.c | 3 ++- Acked. -- Karsten Keil SuSE Labs ISDN and VOIP development SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Remove #warnings for longstanding conditions. 2007-10-25 8:06 ` [PATCH] Remove #warnings for longstanding conditions Jeff Garzik 2007-10-25 9:52 ` Karsten Keil @ 2007-10-25 11:22 ` Matthew Wilcox 2007-10-26 2:07 ` Jeff Garzik 1 sibling, 1 reply; 6+ messages in thread From: Matthew Wilcox @ 2007-10-25 11:22 UTC (permalink / raw) To: Jeff Garzik; +Cc: LKML, linux-scsi, akpm, willy, kkeil On Thu, Oct 25, 2007 at 04:06:15AM -0400, Jeff Garzik wrote: > drivers/scsi/advansys.c:71:2: warning: #warning this driver is still > not properly converted to the DMA API > > ...represent conditions that have existed for years, and are duly noted > in FIXMEs. There does not seem to be much need to warn on every kernel > build for a driver bug or handicap that has existed for years. I'll be removing this #warning from advansys when I get rid of the last bus_to_virt. Which I've already done ... it's just that the resulting driver works on i386, but crashes parisc, so there's clearly a bug. I haven't had time to track it down yet. So NACK this patch. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Remove #warnings for longstanding conditions. 2007-10-25 11:22 ` Matthew Wilcox @ 2007-10-26 2:07 ` Jeff Garzik 2007-10-26 2:14 ` Matthew Wilcox 0 siblings, 1 reply; 6+ messages in thread From: Jeff Garzik @ 2007-10-26 2:07 UTC (permalink / raw) To: Matthew Wilcox; +Cc: LKML, linux-scsi, akpm, Linus Torvalds Matthew Wilcox wrote: >> drivers/scsi/advansys.c:71:2: warning: #warning this driver is still >> not properly converted to the DMA API > I'll be removing this #warning from advansys when I get rid of the > last bus_to_virt. Which I've already done ... it's just that the > resulting driver works on i386, but crashes parisc, so there's clearly a > bug. I haven't had time to track it down yet. So NACK this patch. Well, two main questions... Is this warning of value to anybody but you? Is this information worth printing out on everyone else's kernel build? If yes, great! But it sounds like this warning is analagous to #warning willy's TODO list: get milk, buy groceries, read email, ... which doesn't add much value to others' kernel builds :) Jeff ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Remove #warnings for longstanding conditions. 2007-10-26 2:07 ` Jeff Garzik @ 2007-10-26 2:14 ` Matthew Wilcox 2007-10-26 2:19 ` Jeff Garzik 0 siblings, 1 reply; 6+ messages in thread From: Matthew Wilcox @ 2007-10-26 2:14 UTC (permalink / raw) To: Jeff Garzik; +Cc: LKML, linux-scsi, akpm, Linus Torvalds On Thu, Oct 25, 2007 at 10:07:17PM -0400, Jeff Garzik wrote: > Is this warning of value to anybody but you? Yup. It signals this driver isn't production quality yet. > Is this information worth printing out on everyone else's kernel build? I thnk that's worth noting to anyone who's enabled it. > If yes, great! But it sounds like this warning is analagous to > > #warning willy's TODO list: get milk, buy groceries, read email, ... > > which doesn't add much value to others' kernel builds :) I didn't add the #warning; it was there before 2.6.12-rc2. I haven't added warnings for anything else on the todo list (which remains mightily long, but I'm acually crossing things off it rather than just adding to it now). -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Remove #warnings for longstanding conditions. 2007-10-26 2:14 ` Matthew Wilcox @ 2007-10-26 2:19 ` Jeff Garzik 0 siblings, 0 replies; 6+ messages in thread From: Jeff Garzik @ 2007-10-26 2:19 UTC (permalink / raw) To: Matthew Wilcox; +Cc: LKML, linux-scsi, akpm, Linus Torvalds Matthew Wilcox wrote: > On Thu, Oct 25, 2007 at 10:07:17PM -0400, Jeff Garzik wrote: >> Is this warning of value to anybody but you? > > Yup. It signals this driver isn't production quality yet. > >> Is this information worth printing out on everyone else's kernel build? > > I thnk that's worth noting to anyone who's enabled it. OK, thanks! Jeff ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-10-26 2:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <a576b5944eb04a18d4df3dd27cd32e7f13601470.1193299380.git.jeff@garzik.org>
2007-10-25 8:06 ` [PATCH] Remove #warnings for longstanding conditions Jeff Garzik
2007-10-25 9:52 ` Karsten Keil
2007-10-25 11:22 ` Matthew Wilcox
2007-10-26 2:07 ` Jeff Garzik
2007-10-26 2:14 ` Matthew Wilcox
2007-10-26 2:19 ` Jeff Garzik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).