From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Richter Subject: Re: [PATCH] sysfs: add filter function to groups Date: Mon, 29 Oct 2007 18:58:40 +0100 Message-ID: <47261F50.3050901@s5r6.in-berlin.de> References: <1193671019.3383.13.camel@localhost.localdomain> <1193676852.2655.21.camel@lov.site> <1193677071.3383.56.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from hp3.statik.tu-cottbus.de ([141.43.120.68]:41062 "EHLO hp3.statik.tu-cottbus.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752752AbXJ2R6m (ORCPT ); Mon, 29 Oct 2007 13:58:42 -0400 In-Reply-To: <1193677071.3383.56.camel@localhost.localdomain> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Kay Sievers , Greg KH , linux-scsi , linux-kernel James Bottomley wrote: >> > struct attribute_group { >> > const char *name; >> > + int (*filter_show)(struct kobject *, int); > Actually, it returns a true/false value indicating whether the given > attribute should be displayed. How about this: int (*is_visible)(...); or bool (*shall_be_shown)(...); or bool (*should_be_displayed)(...); or whatever, so that it indicates that this function merely answers a question, but doesn't filter nor show anything. -- Stefan Richter -=====-=-=== =-=- ===-= http://arcgraph.de/sr/