Re: [PATCH] sysfs: add filter function to groups

Cornelia Huck
2007-10-30T09:00:51Z

On Mon, 29 Oct 2007 12:29:27 -0500,
James Bottomley <James.Bottomley@SteelEye.com> wrote:

> On Mon, 2007-10-29 at 13:27 -0400, Jeff Garzik wrote:
> > James Bottomley wrote:
> > > visibility and creation are the same thing, aren't they? An invisible
> > > attribute doesn't appear in the sysfs directory, so it's equivalent to
> > > the file for it not being created.
> >
> >
> > What about the case where it's visible at creation time, but then needs
> > to be made selectively invisible later on?
> >
> > That implies either a remove operation or dentry checks on each lookup?
>
> Yes, that comes with the bitmap manipulation code. There will be a way
> to add and remove runtime visibility. I just wanted to get the basic
> concept agreed to first.

But visibility always comes with creation or deletion of attributes?

Perhaps what we want is to move knowledge of the attributes to the
kobject (when attributes are created/deleted), while we decide on
visibilty of the attributes (creation/deletion of sysfs entries) based
on a filter (where visibility may change, while the attribute still
exists).