Re: [PATCH] sysfs: add filter function to groups

Greg KH
2007-11-04T19:01:13Z

On Sun, Nov 04, 2007 at 08:12:02AM -0600, James Bottomley wrote:
> On Wed, 2007-10-31 at 10:29 -0700, Greg KH wrote:
> > On Wed, Oct 31, 2007 at 09:38:04AM -0500, James Bottomley wrote:
> > > On Tue, 2007-10-30 at 20:55 -0700, Greg KH wrote:
> > > > OSame problem here, if grp->is_visible is not set, sysfs_add_file() would
> > > > never be called, right?
> > > >
> > > > Other than the logic problem (I think), I have no issue with this idea
> > > > at all. Care to redo this so it works?
> > >
> > > It's a fair cop govenor ... new patch attached.
> >
> > Much better, thanks :)
> >
> > I have no problem with this, if you want to take this in your tree,
> > please do and feel free to add:
> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> >
> > to it, or I can take it in mine.
>
> Actually, I think I have a use for it and the follow on patch (coming
> soon) to do attribute bitmaps in the SCSI tree, so I'd like to add your
> ack and take it through this tree.

That's fine. Can you CC: me on the patch that uses this code so I can
see how well it works out?

thanks,

greg k-h