From: Randy Dunlap <randy.dunlap@oracle.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: rae l <crquan@gmail.com>, Joe Perches <joe@perches.com>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ide-scsi: use print_hex_dump from <linux/kernel.h>
Date: Mon, 26 Nov 2007 08:54:04 -0800 [thread overview]
Message-ID: <474AFA2C.5080800@oracle.com> (raw)
In-Reply-To: <20071126132513.GA3230@parisc-linux.org>
Matthew Wilcox wrote:
> On Mon, Nov 26, 2007 at 04:37:50PM +0800, rae l wrote:
>> I know this is different from the original hexdump in ide-scsi.c, I
>> just want to tell someone that there's a good implementation of
>> hexdump in kernel.h, and I think the default KERN_DEBUG and
>> print_hex_dump is more informative and has better output. However,
>> anyone want more precise control on debug message could make her/his
>> improvements with print_hex_dump.
>
> using KERN_DEBUG is wrong -- this is part of a line, so you need to use
> KERN_NONE or simply "".
s/KERN_NONE/KERN_CONT/ for continuation lines.
--
~Randy
next prev parent reply other threads:[~2007-11-26 16:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 7:16 [PATCH 2/2] ide-scsi: use print_hex_dump from <linux/kernel.h> Denis Cheng
[not found] ` <1196062867.8948.25.camel@localhost>
2007-11-26 8:37 ` rae l
2007-11-26 13:25 ` Matthew Wilcox
2007-11-26 16:54 ` Randy Dunlap [this message]
2007-11-27 9:31 ` Andrew Morton
2007-11-27 19:34 ` Joe Perches
2007-11-27 20:34 ` Bartlomiej Zolnierkiewicz
2007-11-27 21:02 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474AFA2C.5080800@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=crquan@gmail.com \
--cc=joe@perches.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).