Recent sym53c8xx patches

Recent sym53c8xx patches

[Tony Battersby]

Hello,

I am sending this message to check up on the merge status of my recent
sym53c8xx patches to make sure they aren't forgotten.  Matthew Wilcox,
could you give an ack/nak for these merge requests?  Also, please let me
know if I need to do anything else (such as resending later) to make
sure these patches get merged.

[PATCH] [SCSI] sym53c8xx: fix free_irq() regression in 2.6.24
http://marc.info/?t=119438263300007&r=1&w=4
Regression fix.  Should be merged in 2.6.24.  OK'ed by Christoph Hellwig.

[PATCH] [SCSI] sym53c8xx: fix resid calculation
http://marc.info/?l=linux-scsi&m=119438360705773&w=4
Bug fix.  I would like it to be merged in 2.6.24.  No replies to initial
message.

[PATCH] [SCSI] sym53c8xx: don't flood syslog with negotiation messages
http://marc.info/?l=linux-scsi&m=119446914818689&w=4
More an annoyance fix than a bug fix.  Probably safe to merge for
2.6.24, but could wait for 2.6.25 if someone objects.  No replies to
initial message.

[PATCH] [SCSI] sym53c8xx: fix setflag user command to control disconnects
http://marc.info/?l=linux-scsi&m=119446790116497&w=4
Fix for long-broken not-widely-used feature.  Can be dropped if the
disconnect attribute will be added to the SPI transport class in the
near future.  Is anyone working on this BTW?

[PATCH] [SCSI] sym53c8xx: increase sg_tablesize for larger data transfers
http://marc.info/?l=linux-scsi&m=119513922112712&w=4
Enhancement.  On hold for the moment due to speculation that it may
break some 875 chips.

Thanks,
Tony Battersby

Re: Recent sym53c8xx patches

[Randy Dunlap]

On Tue, 27 Nov 2007 09:51:56 -0500 Tony Battersby wrote:

> Hello,
> 
> I am sending this message to check up on the merge status of my recent
> sym53c8xx patches to make sure they aren't forgotten.  Matthew Wilcox,
> could you give an ack/nak for these merge requests?  Also, please let me
> know if I need to do anything else (such as resending later) to make
> sure these patches get merged.

Is Matthew assisting James on SCSI merges now?


More broadly speaking, it would be a Good Thing if the SCSI
maintainer(s) would ack patches and/or merge them in a more timely
manner, like most other kernel subsystem maintainers.


---
~Randy

Re: Recent sym53c8xx patches

[Tony Battersby]

Randy Dunlap wrote:
> Is Matthew assisting James on SCSI merges now?
>
>   
Matthew is the maintainer of sym53c8xx.  I figured my patches weren't
getting merged since he hadn't given the ok yet.

Tony

Re: Recent sym53c8xx patches

[Tony Battersby]

Tony Battersby wrote:
> Hello,
>
> I am sending this message to check up on the merge status of my recent
> sym53c8xx patches to make sure they aren't forgotten.  Matthew Wilcox,
> could you give an ack/nak for these merge requests?  Also, please let me
> know if I need to do anything else (such as resending later) to make
> sure these patches get merged.
>
> [PATCH] [SCSI] sym53c8xx: fix free_irq() regression in 2.6.24
> http://marc.info/?t=119438263300007&r=1&w=4
> Regression fix.  Should be merged in 2.6.24.  OK'ed by Christoph Hellwig.
>
> [PATCH] [SCSI] sym53c8xx: fix resid calculation
> http://marc.info/?l=linux-scsi&m=119438360705773&w=4
> Bug fix.  I would like it to be merged in 2.6.24.  No replies to initial
> message.
>
> [PATCH] [SCSI] sym53c8xx: don't flood syslog with negotiation messages
> http://marc.info/?l=linux-scsi&m=119446914818689&w=4
> More an annoyance fix than a bug fix.  Probably safe to merge for
> 2.6.24, but could wait for 2.6.25 if someone objects.  No replies to
> initial message.
>
> [PATCH] [SCSI] sym53c8xx: fix setflag user command to control disconnects
> http://marc.info/?l=linux-scsi&m=119446790116497&w=4
> Fix for long-broken not-widely-used feature.  Can be dropped if the
> disconnect attribute will be added to the SPI transport class in the
> near future.  Is anyone working on this BTW?
>
> [PATCH] [SCSI] sym53c8xx: increase sg_tablesize for larger data transfers
> http://marc.info/?l=linux-scsi&m=119513922112712&w=4
> Enhancement.  On hold for the moment due to speculation that it may
> break some 875 chips.
>
> Thanks,
> Tony Battersby
>
>
>   
I have waited a week, and I still have not received any replies from
Matthew.  I do however see that he has sent other messages to other
people, so I don't believe that he is offline.  At this point I am
beginning to wonder if he is receiving my messages at all.  I can't
imagine that I did anything offensive; perhaps a well-meaning junk mail
rule just doesn't like me for some reason.

James, would you be willing to apply any of these patches without an
explicit ack from Matthew (the sym53c8xx maintainer)?  And could someone
else please try contacting Matthew to see what's up?

Side note: I have been operating under the assumption that patches
against a driver should be acked by the maintainer of that driver before
being merged.  If that is not the case, then Matthew's reply isn't
really that important, and I apologize for nagging.

Thanks,
Tony Battersby
Cybernetics

Re: Recent sym53c8xx patches

[James Bottomley]

On Tue, 2007-11-27 at 09:51 -0500, Tony Battersby wrote:
> Hello,
> 
> I am sending this message to check up on the merge status of my recent
> sym53c8xx patches to make sure they aren't forgotten.  Matthew Wilcox,
> could you give an ack/nak for these merge requests?  Also, please let me
> know if I need to do anything else (such as resending later) to make
> sure these patches get merged.
> 
> [PATCH] [SCSI] sym53c8xx: fix free_irq() regression in 2.6.24
> http://marc.info/?t=119438263300007&r=1&w=4
> Regression fix.  Should be merged in 2.6.24.  OK'ed by Christoph Hellwig.
> 
> [PATCH] [SCSI] sym53c8xx: fix resid calculation
> http://marc.info/?l=linux-scsi&m=119438360705773&w=4
> Bug fix.  I would like it to be merged in 2.6.24.  No replies to initial
> message.

These two I have flagged for inclusion.

> [PATCH] [SCSI] sym53c8xx: don't flood syslog with negotiation messages
> http://marc.info/?l=linux-scsi&m=119446914818689&w=4
> More an annoyance fix than a bug fix.  Probably safe to merge for
> 2.6.24, but could wait for 2.6.25 if someone objects.  No replies to
> initial message.

This one I'd like to wait on maintainer feedback

> [PATCH] [SCSI] sym53c8xx: fix setflag user command to control disconnects
> http://marc.info/?l=linux-scsi&m=119446790116497&w=4
> Fix for long-broken not-widely-used feature.  Can be dropped if the
> disconnect attribute will be added to the SPI transport class in the
> near future.  Is anyone working on this BTW?

This one, I was sort of expecting, since you want the feature that you'd
add it to the transport class ...

> [PATCH] [SCSI] sym53c8xx: increase sg_tablesize for larger data transfers
> http://marc.info/?l=linux-scsi&m=119513922112712&w=4
> Enhancement.  On hold for the moment due to speculation that it may
> break some 875 chips.

I'd like more feedback, but sometimes the best way of testing things
like this is to stick it in the field and see if it breaks something.

James