* [OpenFCoE PATCH] Add a missing spin_unlock() found when a BLS frame was mis-delivered.
@ 2007-12-05 0:51 Joe Eykholt
2007-12-05 0:56 ` Joe Eykholt
0 siblings, 1 reply; 4+ messages in thread
From: Joe Eykholt @ 2007-12-05 0:51 UTC (permalink / raw)
To: linux-scsi
Add a missing spin_unlock() found when a BLS frame was mis-delivered.
Signed-off-by: Joe Eykholt <fcoe@eykholt.com>
---
drivers/scsi/ofc/openfc/openfc_scsi.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/ofc/openfc/openfc_scsi.c b/drivers/scsi/ofc/openfc/openfc_scsi.c
index 86e6895..5fa0ad6 100644
--- a/drivers/scsi/ofc/openfc/openfc_scsi.c
+++ b/drivers/scsi/ofc/openfc/openfc_scsi.c
@@ -548,6 +548,8 @@ void openfc_scsi_abort_iocontext(struct fc_scsi_pkt *fsp)
fsp->status_code = OPENFC_ERROR;
fsp->io_status = (SUGGEST_RETRY << 24);
(*fsp->done) (fsp);
+ } else {
+ spin_unlock(&qp->scsi_pkt_lock);
}
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [OpenFCoE PATCH] Add a missing spin_unlock() found when a BLS frame was mis-delivered.
2007-12-05 0:51 [OpenFCoE PATCH] Add a missing spin_unlock() found when a BLS frame was mis-delivered Joe Eykholt
@ 2007-12-05 0:56 ` Joe Eykholt
0 siblings, 0 replies; 4+ messages in thread
From: Joe Eykholt @ 2007-12-05 0:56 UTC (permalink / raw)
To: linux-scsi
Joe Eykholt wrote:
> Add a missing spin_unlock() found when a BLS frame was mis-delivered.
Please disregard this patch. It got merged into the wrong function. A better one is coming.
Joe
> Signed-off-by: Joe Eykholt <fcoe@eykholt.com>
>
> ---
> drivers/scsi/ofc/openfc/openfc_scsi.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/ofc/openfc/openfc_scsi.c b/drivers/scsi/ofc/openfc/openfc_scsi.c
> index 86e6895..5fa0ad6 100644
> --- a/drivers/scsi/ofc/openfc/openfc_scsi.c
> +++ b/drivers/scsi/ofc/openfc/openfc_scsi.c
> @@ -548,6 +548,8 @@ void openfc_scsi_abort_iocontext(struct fc_scsi_pkt *fsp)
> fsp->status_code = OPENFC_ERROR;
> fsp->io_status = (SUGGEST_RETRY << 24);
> (*fsp->done) (fsp);
> + } else {
> + spin_unlock(&qp->scsi_pkt_lock);
> }
> }
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [OpenFCoE PATCH] Add a missing spin_unlock() found when a BLS frame was mis-delivered.
@ 2007-12-05 1:30 Joe Eykholt
0 siblings, 0 replies; 4+ messages in thread
From: Joe Eykholt @ 2007-12-05 1:30 UTC (permalink / raw)
To: linux-scsi
Add a missing spin_unlock() found when a BLS frame was mis-delivered.
Signed-off-by: Joe Eykholt <fcoe@eykholt.com>
---
drivers/scsi/ofc/openfc/openfc_scsi.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/ofc/openfc/openfc_scsi.c b/drivers/scsi/ofc/openfc/openfc_scsi.c
index 9e66c5f..6adfd59 100644
--- a/drivers/scsi/ofc/openfc/openfc_scsi.c
+++ b/drivers/scsi/ofc/openfc/openfc_scsi.c
@@ -580,6 +580,8 @@ static void openfc_scsi_rcv(struct fc_seq *sp, struct fc_frame *fp, void *arg)
fc_seq_exch_complete(sp);
fsp->state = OPENFC_SRB_RCV_STATUS;
(*fsp->done) (fsp);
+ } else {
+ spin_unlock(&qp->scsi_pkt_lock);
}
out:
fc_frame_free(fp);
^ permalink raw reply related [flat|nested] 4+ messages in thread* [OpenFCoE] [PATCH] Add a missing spin_unlock() found when a BLS frame was mis-delivered.
@ 2007-11-30 18:35 Joe Eykholt
0 siblings, 0 replies; 4+ messages in thread
From: Joe Eykholt @ 2007-11-30 18:35 UTC (permalink / raw)
To: linux-scsi
Add a missing spin_unlock() found when a BLS frame was mis-delivered.
---
drivers/scsi/ofc/openfc/openfc_scsi.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/ofc/openfc/openfc_scsi.c b/drivers/scsi/ofc/openfc/openfc_scsi.c
index 86e6895..5fa0ad6 100644
--- a/drivers/scsi/ofc/openfc/openfc_scsi.c
+++ b/drivers/scsi/ofc/openfc/openfc_scsi.c
@@ -548,6 +548,8 @@ void openfc_scsi_abort_iocontext(struct fc_scsi_pkt *fsp)
fsp->status_code = OPENFC_ERROR;
fsp->io_status = (SUGGEST_RETRY << 24);
(*fsp->done) (fsp);
+ } else {
+ spin_unlock(&qp->scsi_pkt_lock);
}
}
--
1.5.3.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-12-05 1:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-05 0:51 [OpenFCoE PATCH] Add a missing spin_unlock() found when a BLS frame was mis-delivered Joe Eykholt
2007-12-05 0:56 ` Joe Eykholt
-- strict thread matches above, loose matches on Subject: below --
2007-12-05 1:30 Joe Eykholt
2007-11-30 18:35 [OpenFCoE] [PATCH] " Joe Eykholt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox