* [PATCH 10/20] drivers/scsi/ipr.c: use LIST_HEAD instead of LIST_HEAD_INIT
@ 2007-12-06 15:21 Denis Cheng
2007-12-06 17:05 ` Brian King
0 siblings, 1 reply; 2+ messages in thread
From: Denis Cheng @ 2007-12-06 15:21 UTC (permalink / raw)
To: linux-scsi; +Cc: Andrew Morton, linux-kernel
single list_head variable initialized with LIST_HEAD_INIT could almost
always can be replaced with LIST_HEAD declaration, this shrinks the code
and looks better.
Signed-off-by: Denis Cheng <crquan@gmail.com>
---
drivers/scsi/ipr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index 0841df0..9018ee8 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -84,7 +84,7 @@
/*
* Global Data
*/
-static struct list_head ipr_ioa_head = LIST_HEAD_INIT(ipr_ioa_head);
+static LIST_HEAD(ipr_ioa_head);
static unsigned int ipr_log_level = IPR_DEFAULT_LOG_LEVEL;
static unsigned int ipr_max_speed = 1;
static int ipr_testmode = 0;
--
1.5.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 10/20] drivers/scsi/ipr.c: use LIST_HEAD instead of LIST_HEAD_INIT
2007-12-06 15:21 [PATCH 10/20] drivers/scsi/ipr.c: use LIST_HEAD instead of LIST_HEAD_INIT Denis Cheng
@ 2007-12-06 17:05 ` Brian King
0 siblings, 0 replies; 2+ messages in thread
From: Brian King @ 2007-12-06 17:05 UTC (permalink / raw)
To: Denis Cheng; +Cc: linux-scsi, Andrew Morton, linux-kernel
Acked-by: Brian King <brking@linux.vnet.ibm.com>
Denis Cheng wrote:
> single list_head variable initialized with LIST_HEAD_INIT could almost
> always can be replaced with LIST_HEAD declaration, this shrinks the code
> and looks better.
>
> Signed-off-by: Denis Cheng <crquan@gmail.com>
> ---
> drivers/scsi/ipr.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
> index 0841df0..9018ee8 100644
> --- a/drivers/scsi/ipr.c
> +++ b/drivers/scsi/ipr.c
> @@ -84,7 +84,7 @@
> /*
> * Global Data
> */
> -static struct list_head ipr_ioa_head = LIST_HEAD_INIT(ipr_ioa_head);
> +static LIST_HEAD(ipr_ioa_head);
> static unsigned int ipr_log_level = IPR_DEFAULT_LOG_LEVEL;
> static unsigned int ipr_max_speed = 1;
> static int ipr_testmode = 0;
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-06 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-06 15:21 [PATCH 10/20] drivers/scsi/ipr.c: use LIST_HEAD instead of LIST_HEAD_INIT Denis Cheng
2007-12-06 17:05 ` Brian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).