From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH] megaraid: fix section mismatch Date: Thu, 10 Jan 2008 20:51:59 -0800 Message-ID: <4786F5EF.2000101@oracle.com> References: <20080110143316.071efbc1.randy.dunlap@oracle.com> <20080110161023.91bf7618.akpm@linux-foundation.org> <1200026735.5337.3.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from agminet01.oracle.com ([141.146.126.228]:56187 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756842AbYAKExO (ORCPT ); Thu, 10 Jan 2008 23:53:14 -0500 In-Reply-To: <1200026735.5337.3.camel@localhost.localdomain> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Andrew Morton , megaraidlinux@lsi.com, linux-scsi@vger.kernel.org, sam@ravnborg.org, Mauro Carvalho Chehab , Ingo Molnar James Bottomley wrote: > On Thu, 2008-01-10 at 16:10 -0800, Andrew Morton wrote: >> On Thu, 10 Jan 2008 14:33:16 -0800 >> Randy Dunlap wrote: >> >>> From: Randy Dunlap >>> >>> Change megaraid_pci_driver_g variable name so that it matches the modpost >>> whitelist that allows pointers to init text/data. >>> >>> WARNING: vmlinux.o(.data+0x1a8e30): Section mismatch: reference to .init.text:megaraid_probe_one (between 'megaraid_pci_driver_g' and 'class_device_attr_megaraid_mbox_app_hndl') >>> >> All these patches fix references to possibly-discarded sections and hence >> fix possibly-serious bugs. So all of them should go into 2.6.24. > > Renaming a variable fixes a serious bug? It quiets a spurious warning > from modpost, sure, but I hardly think that's -rc7 material. Right. The variable-renaming patches are for: tpm_infineon hostap av7110 megaraid The other 4 are more serious. -- ~Randy